Bug 207484

Summary: arm64_32: Mark microbenchmarks/delete-property-keeps-cacheable-structure.js is timing out on all Apple Watch models
Product: WebKit Reporter: Justin Michaud <justin_michaud>
Component: New BugsAssignee: Justin Michaud <justin_michaud>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, ryanhaddad, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Justin Michaud
Reported 2020-02-10 11:03:53 PST
arm64_32: microbenchmarks/delete-property-keeps-cacheable-structure.js is timing out
Attachments
Patch (1.33 KB, patch)
2020-02-10 11:04 PST, Justin Michaud 		no flags
DetailsFormatted DiffDiff
Patch (1.30 KB, patch)
2020-02-10 11:20 PST, Justin Michaud 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Justin Michaud
Comment 1 2020-02-10 11:04:20 PST
Created attachment 390268 [details] Patch
Justin Michaud
Comment 2 2020-02-10 11:05:27 PST
rdar://59262882
Yusuke Suzuki
Comment 3 2020-02-10 11:10:50 PST
Comment on attachment 390268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390268&action=review r=me > JSTests/microbenchmarks/delete-property-keeps-cacheable-structure.js:1 > +//@ skip if $architecture == "arm64_32" or $architecture == "arm7k" Should we use something like, `$model =~ /^Apple Watch/` etc.? But I don't have strong preference.
Justin Michaud
Comment 4 2020-02-10 11:20:46 PST
Created attachment 390272 [details] Patch
WebKit Commit Bot
Comment 5 2020-02-10 12:09:49 PST
Comment on attachment 390272 [details] Patch Clearing flags on attachment: 390272 Committed r256199: <https://trac.webkit.org/changeset/256199>
WebKit Commit Bot
Comment 6 2020-02-10 12:09:50 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 7 2020-02-10 14:12:59 PST
Re-titling, because this wasn't fixed, just the test skipped.
Mark Lam
Comment 8 2020-04-01 16:11:55 PDT
(In reply to Alexey Proskuryakov from comment #7) > Re-titling, because this wasn't fixed, just the test skipped.
Mark Lam
Comment 9 2020-04-01 16:13:43 PDT
(In reply to Mark Lam from comment #8) > (In reply to Alexey Proskuryakov from comment #7) > > Re-titling, because this wasn't fixed, just the test skipped. There's nothing more to fix here. The test runs 5000000 iterations of its workload. On Apple Watch which doesn't use the JIT, this is going to take forever, and will surely time out. Skipping it is the right thing to do.
Note You need to log in before you can comment on or make changes to this bug.