Bug 207453

Summary: Fix declarations marked by wrong export macros (WEBCORE_EXPORT and WTF_EXPORT)
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: Web Template FrameworkAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, don.olmstead, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=207380
https://bugs.webkit.org/show_bug.cgi?id=207746
Attachments:
Description Flags
Patch ross.kirsling: review+

Fujii Hironori
Reported 2020-02-09 22:31:33 PST
Fix declarations marked by wrong export macros (WEBCORE_EXPORT and WTF_EXPORT) I'm going to add a new rule build/export_macro to check-webkit-style in Bug 207380. It detects style errors in existing code (Bug 207380 Comment 4). See also: Bug 207380 – check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories Bug 203876 – WEBCORE_TESTSUPPORT_EXPORT should be used only for WebCoreTestSupport, not for WebCore
Attachments
Patch (19.22 KB, patch)
2020-02-09 22:43 PST, Fujii Hironori 		ross.kirsling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2020-02-09 22:43:16 PST
Created attachment 390234 [details] Patch
Ross Kirsling
Comment 2 2020-02-10 10:08:25 PST
Comment on attachment 390234 [details] Patch r=me. I'm surprised there are so many!
Fujii Hironori
Comment 3 2020-02-11 18:01:13 PST
Committed r256420: <https://trac.webkit.org/changeset/256420>
Radar WebKit Bug Importer
Comment 4 2020-02-11 18:02:17 PST
<rdar://problem/59372199>
Note You need to log in before you can comment on or make changes to this bug.