Bug 207449

Summary: [WK2][Soup] Implement NetworkStorageSession::getAllCookies
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: WebKit2Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, berto, cgarcia, commit-queue, ews-watchlist, gustavo, webkit-bug-importer, yurys
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Pavel Feldman
Reported 2020-02-09 20:29:51 PST
Getting is implemented for GTK/WPE ports.
Attachments
Patch (1.75 KB, patch)
2020-02-09 20:31 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2020-02-09 20:31:30 PST
Created attachment 390228 [details] Patch
Carlos Garcia Campos
Comment 2 2020-02-10 00:15:18 PST
Comment on attachment 390228 [details] Patch This looks good, but it seems to be deadcode for ports using libsoup. Why do you need this? This is only used by cocoa API, I think.
Pavel Feldman
Comment 3 2020-02-11 13:10:27 PST
Thanks for looking into it. This achieves feature parity with the Cocoa API in terms of raw cookie management. We'd like to be able to manage cookies on the datastore / processpool level over the remote debugging protocol. The harness / web inspector client is not there (yet) and it'll take time, so this does not make any tests green yet. But it looks innocent in terms of adding simple yet functional implementations for those.
Carlos Garcia Campos
Comment 4 2020-02-12 01:13:11 PST
Comment on attachment 390228 [details] Patch Ok, then. Thanks!
WebKit Commit Bot
Comment 5 2020-02-12 18:13:16 PST
Comment on attachment 390228 [details] Patch Clearing flags on attachment: 390228 Committed r256496: <https://trac.webkit.org/changeset/256496>
WebKit Commit Bot
Comment 6 2020-02-12 18:13:18 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2020-02-12 18:14:17 PST
<rdar://problem/59409694>
Note You need to log in before you can comment on or make changes to this bug.