Summary: | [WK2][Soup] Implement NetworkStorageSession::getAllCookies | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||
Component: | WebKit2 | Assignee: | Pavel Feldman <pfeldman> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aperez, berto, cgarcia, commit-queue, ews-watchlist, gustavo, webkit-bug-importer, yurys | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Pavel Feldman
2020-02-09 20:29:51 PST
Created attachment 390228 [details]
Patch
Comment on attachment 390228 [details]
Patch
This looks good, but it seems to be deadcode for ports using libsoup. Why do you need this? This is only used by cocoa API, I think.
Thanks for looking into it. This achieves feature parity with the Cocoa API in terms of raw cookie management. We'd like to be able to manage cookies on the datastore / processpool level over the remote debugging protocol. The harness / web inspector client is not there (yet) and it'll take time, so this does not make any tests green yet. But it looks innocent in terms of adding simple yet functional implementations for those. Comment on attachment 390228 [details]
Patch
Ok, then. Thanks!
Comment on attachment 390228 [details] Patch Clearing flags on attachment: 390228 Committed r256496: <https://trac.webkit.org/changeset/256496> All reviewed patches have been landed. Closing bug. |