| Summary: | Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, darin, dbates, ews-watchlist, keith_miller, mark.lam, msaboff, saam, thorton, tsavell, tzagallo, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Sam Weinig
2020-02-08 17:34:30 PST
Created attachment 390189 [details]
Patch
Committed r256103: <https://trac.webkit.org/changeset/256103> Reverted r256103 for reason: This patch is blocking the rollout of r256091 Committed r256183: <https://trac.webkit.org/changeset/256183> Created attachment 392658 [details]
Patch
Created attachment 392815 [details]
Patch
Comment on attachment 392815 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392815&action=review So glad you are doing this. Really not happy with FeatureDefines.xcconfig and wondering if we need it at all. > Source/WTF/wtf/PlatformEnableCocoa.h:255 > +#if !defined(ENABLE_FAST_JIT_PERMISSIONS) && CPU(ARM64) && !(OS(TVOS) || OS(WATCHOS)) && USE(APPLE_INTERNAL_SDK) Looks good. I wonder about PLATFORM(APPLETV) vs. OS(TVOS); I think I’d almost always prefer OS(TVOS), but PLATFORM(APPLETV) seems much more common. I wonder about PLATFORM(WATCHOS) vs. OS(WATCHOS). Committed r258076: <https://trac.webkit.org/changeset/258076> |