redefined WTF_USE_JSC macro

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

WebCore/WebCore.pro defines WTF_USE_JSC=1, assigned to compiler command line. But WebCore/config.h also defines WTF_USE_JSC: #define WTF_USE_JSC !WTF_USE_V8. The macro redifinig is warning according to gcc. I think it should be fixed. One way to remove defining WTF_USE_JSC from WebCore.pro. The other way to use #undef macro in config.h, if WTF_USE_JSC defined before.

[Csaba Osztrogonác]

Created attachment 23290 [details]
proposed patch

Undef WTF_USE_JSC before redefining.

[Csaba Osztrogonác]

Created attachment 23292 [details]
proposed patch

Defining unnecessary WTF_USE_JSC macro removed.

[Mark Rowe (bdash)]

Please pick the patch that you feel is appropriate and set it for review.  The two you have provided appear to be mutually exclusive.  Please also include a ChangeLog entry.

[Mark Rowe (bdash)]

My bad, you did include ChangeLog entries.  Please mark the patch that you feel is the right approach for review.

[Csaba Osztrogonác]

Comment on attachment 23292 [details]
proposed patch

WTF_USE_JSC=1 defined by http://trac.webkit.org/changeset/36268 because of Qt/Windows build.

[Csaba Osztrogonác]

(In reply to comment #4)
I marked one of my patyh for review. The other patch is bad as I mentioned in my previous remark.

[Eric Seidel (no email)]

Comment on attachment 23290 [details]
proposed patch

The way we would normally do this is:

#ifndef WTF_USE_JSC
#define WTF_USE_JSC !WTF_USE_V8
#endif

[Csaba Osztrogonác]

This bug fixed by other, landed in r36439 (http://trac.webkit.org/changeset/36439)