Bug 20743

Summary: redefined WTF_USE_JSC macro
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch
eric: review-
proposed patch none

Csaba Osztrogonác
Reported 2008-09-09 04:36:56 PDT
WebCore/WebCore.pro defines WTF_USE_JSC=1, assigned to compiler command line. But WebCore/config.h also defines WTF_USE_JSC: #define WTF_USE_JSC !WTF_USE_V8. The macro redifinig is warning according to gcc. I think it should be fixed. One way to remove defining WTF_USE_JSC from WebCore.pro. The other way to use #undef macro in config.h, if WTF_USE_JSC defined before.
Attachments
proposed patch (884 bytes, patch)
2008-09-09 04:43 PDT, Csaba Osztrogonác 		eric: review-
DetailsFormatted DiffDiff
proposed patch (1.14 KB, patch)
2008-09-09 04:54 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2008-09-09 04:43:05 PDT
Created attachment 23290 [details] proposed patch Undef WTF_USE_JSC before redefining.
Csaba Osztrogonác
Comment 2 2008-09-09 04:54:44 PDT
Created attachment 23292 [details] proposed patch Defining unnecessary WTF_USE_JSC macro removed.
Mark Rowe (bdash)
Comment 3 2008-09-09 13:25:02 PDT
Please pick the patch that you feel is appropriate and set it for review. The two you have provided appear to be mutually exclusive. Please also include a ChangeLog entry.
Mark Rowe (bdash)
Comment 4 2008-09-09 13:25:54 PDT
My bad, you did include ChangeLog entries. Please mark the patch that you feel is the right approach for review.
Csaba Osztrogonác
Comment 5 2008-09-09 13:36:48 PDT
Comment on attachment 23292 [details] proposed patch WTF_USE_JSC=1 defined by http://trac.webkit.org/changeset/36268 because of Qt/Windows build.
Csaba Osztrogonác
Comment 6 2008-09-09 13:41:49 PDT
(In reply to comment #4) I marked one of my patyh for review. The other patch is bad as I mentioned in my previous remark.
Eric Seidel (no email)
Comment 7 2008-09-12 12:22:19 PDT
Comment on attachment 23290 [details] proposed patch The way we would normally do this is: #ifndef WTF_USE_JSC #define WTF_USE_JSC !WTF_USE_V8 #endif
Csaba Osztrogonác
Comment 8 2008-09-15 05:35:29 PDT
This bug fixed by other, landed in r36439 (http://trac.webkit.org/changeset/36439)
Note You need to log in before you can comment on or make changes to this bug.