Bug 207410

Summary: [bmalloc] VMHeap can be merge into Heap
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: bmallocAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, basuke, commit-queue, ews-watchlist, ggaren, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
PATCH none

Basuke Suzuki
Reported 2020-02-07 14:45:54 PST
I don't know about the history of VMHeap, but it has only one member function in it and Heap is the only client of that function. No member variable is defined. It does nothing special with its class. It is safe to merge the function into Heap.
Attachments
PATCH (14.40 KB, patch)
2020-02-07 15:14 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2020-02-07 15:14:07 PST
Created attachment 390132 [details] PATCH
Yusuke Suzuki
Comment 2 2020-02-08 01:52:29 PST
Comment on attachment 390132 [details] PATCH r=me, I think VMHeap is no longer necessary too.
WebKit Commit Bot
Comment 3 2020-02-08 02:35:44 PST
Comment on attachment 390132 [details] PATCH Clearing flags on attachment: 390132 Committed r256088: <https://trac.webkit.org/changeset/256088>
WebKit Commit Bot
Comment 4 2020-02-08 02:35:46 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2020-02-08 02:36:14 PST
<rdar://problem/59285145>
Note You need to log in before you can comment on or make changes to this bug.