Bug 207405

Summary: TestWebKitAPI: Disable legacy ActionSheet tests on Catalyst
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2020-02-07 13:57:14 PST
Our ActionSheet tests test behavior not applicable to Catalyst. Disable these tests on Catalyst.
Attachments
Patch (1.08 KB, patch)
2020-02-07 13:59 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.19 KB, patch)
2020-02-07 14:48 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2020-02-07 13:59:44 PST
Created attachment 390119 [details] Patch
Wenson Hsieh
Comment 2 2020-02-07 14:38:22 PST
Comment on attachment 390119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390119&action=review > Tools/TestWebKitAPI/Tests/ios/ActionSheetTests.mm:29 > +#if PLATFORM(IOS_FAMILY) && !PLATFORM(MACCATALYST) You should update the corresponding #endif as well.
Jonathan Bedard
Comment 3 2020-02-07 14:48:24 PST
Created attachment 390128 [details] Patch for landing
WebKit Commit Bot
Comment 4 2020-02-07 15:38:23 PST
Comment on attachment 390128 [details] Patch for landing Clearing flags on attachment: 390128 Committed r256074: <https://trac.webkit.org/changeset/256074>
WebKit Commit Bot
Comment 5 2020-02-07 15:38:24 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2020-02-07 15:39:18 PST
<rdar://problem/59276605>
Note You need to log in before you can comment on or make changes to this bug.