Summary: | Use ObjectIdentifier for WebRTC resolvers | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
youenn fablet
2020-02-07 04:30:51 PST
Created attachment 390074 [details]
Patch
Created attachment 390076 [details]
Patch
Comment on attachment 390076 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390076&action=review > Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:121 > + WebProcess::singleton().libWebRTCNetwork().resolver(makeObjectIdentifier<LibWebRTCResolverIdentifierType>(decoder.destinationID())).didReceiveMessage(connection, decoder); I probably need to make it more robust since destinationID could be zero here. Comment on attachment 390076 [details] Patch Clearing flags on attachment: 390076 Committed r256185: <https://trac.webkit.org/changeset/256185> All reviewed patches have been landed. Closing bug. |