Bug 207381

Summary: Use ObjectIdentifier for WebRTC resolvers
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description youenn fablet 2020-02-07 04:30:51 PST
Use ObjectIdentifier for WebRTC resolvers
Comment 1 youenn fablet 2020-02-07 04:33:47 PST
Created attachment 390074 [details]
Patch
Comment 2 youenn fablet 2020-02-07 06:19:51 PST
Created attachment 390076 [details]
Patch
Comment 3 youenn fablet 2020-02-07 09:57:56 PST
Comment on attachment 390076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390076&action=review

> Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:121
> +        WebProcess::singleton().libWebRTCNetwork().resolver(makeObjectIdentifier<LibWebRTCResolverIdentifierType>(decoder.destinationID())).didReceiveMessage(connection, decoder);

I probably need to make it more robust since destinationID could be zero here.
Comment 4 WebKit Commit Bot 2020-02-10 09:29:50 PST
Comment on attachment 390076 [details]
Patch

Clearing flags on attachment: 390076

Committed r256185: <https://trac.webkit.org/changeset/256185>
Comment 5 WebKit Commit Bot 2020-02-10 09:29:52 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-02-10 09:30:15 PST
<rdar://problem/59313321>