Summary: | Allow UIDNAInfo.errors from uidna_nameToUnicode that would not cause URL parsing failures | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
Component: | Web Template Framework | Assignee: | Alex Christensen <achristensen> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, rniwa, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Alex Christensen
2020-02-06 14:51:30 PST
Created attachment 390007 [details]
patch
The commit-queue encountered the following flaky tests while processing attachment 390007 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 390007 [details]:
The commit-queue is continuing to process your patch.
Comment on attachment 390007 [details] patch Rejecting attachment 390007 [details] from commit-queue. New failing tests: fast/encoding/idn-security.html Full output: https://webkit-queues.webkit.org/results/13318240 Created attachment 390043 [details]
Archive of layout-test-results from webkit-cq-03 for mac-mojave
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03 Port: mac-mojave Platform: Mac OS X 10.14.6
I'm allowing errors for uidna_nameToUnicode, not uidna_nameToASCII. That fixes the test. Created attachment 390783 [details]
Patch
Comment on attachment 390783 [details] Patch Clearing flags on attachment: 390783 Committed r256629: <https://trac.webkit.org/changeset/256629> All reviewed patches have been landed. Closing bug. |