Bug 207360

Summary: Allow UIDNAInfo.errors from uidna_nameToUnicode that would not cause URL parsing failures
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: Web Template FrameworkAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
Archive of layout-test-results from webkit-cq-03 for mac-mojave
none
Patch none

Alex Christensen
Reported 2020-02-06 14:51:30 PST
There are some error codes in the UIDNAInfo used by uidna_nameToUnicode that should not cause domain decoding failures. I allow the ones that are caused by strings that would parse successfully in URLParser, which uses uidna_nameToASCII.
Attachments
patch (3.36 KB, patch)
2020-02-06 14:59 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-cq-03 for mac-mojave (4.23 MB, application/zip)
2020-02-06 18:52 PST, WebKit Commit Bot 		no flags
Details
Patch (3.45 KB, patch)
2020-02-14 10:21 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-02-06 14:59:40 PST
Created attachment 390007 [details] patch
WebKit Commit Bot
Comment 2 2020-02-06 18:36:56 PST
The commit-queue encountered the following flaky tests while processing attachment 390007 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 3 2020-02-06 18:36:57 PST
The commit-queue encountered the following flaky tests while processing attachment 390007 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2020-02-06 18:51:58 PST
Comment on attachment 390007 [details] patch Rejecting attachment 390007 [details] from commit-queue. New failing tests: fast/encoding/idn-security.html Full output: https://webkit-queues.webkit.org/results/13318240
WebKit Commit Bot
Comment 5 2020-02-06 18:52:00 PST
Created attachment 390043 [details] Archive of layout-test-results from webkit-cq-03 for mac-mojave The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-03 Port: mac-mojave Platform: Mac OS X 10.14.6
Alex Christensen
Comment 6 2020-02-14 10:21:23 PST
I'm allowing errors for uidna_nameToUnicode, not uidna_nameToASCII. That fixes the test.
Alex Christensen
Comment 7 2020-02-14 10:21:55 PST
Created attachment 390783 [details] Patch
WebKit Commit Bot
Comment 8 2020-02-14 11:09:38 PST
Comment on attachment 390783 [details] Patch Clearing flags on attachment: 390783 Committed r256629: <https://trac.webkit.org/changeset/256629>
WebKit Commit Bot
Comment 9 2020-02-14 11:09:39 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2020-02-14 11:10:20 PST
<rdar://problem/59465075>
Note You need to log in before you can comment on or make changes to this bug.