Bug 207360

Summary: Allow UIDNAInfo.errors from uidna_nameToUnicode that would not cause URL parsing failures
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: Web Template FrameworkAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
Archive of layout-test-results from webkit-cq-03 for mac-mojave
none
Patch none

Description Alex Christensen 2020-02-06 14:51:30 PST
There are some error codes in the UIDNAInfo used by uidna_nameToUnicode that should not cause domain decoding failures.  I allow the ones that are caused by strings that would parse successfully in URLParser, which uses uidna_nameToASCII.
Comment 1 Alex Christensen 2020-02-06 14:59:40 PST
Created attachment 390007 [details]
patch
Comment 2 WebKit Commit Bot 2020-02-06 18:36:56 PST
The commit-queue encountered the following flaky tests while processing attachment 390007 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2020-02-06 18:36:57 PST
The commit-queue encountered the following flaky tests while processing attachment 390007 [details]:

The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2020-02-06 18:51:58 PST
Comment on attachment 390007 [details]
patch

Rejecting attachment 390007 [details] from commit-queue.

New failing tests:
fast/encoding/idn-security.html
Full output: https://webkit-queues.webkit.org/results/13318240
Comment 5 WebKit Commit Bot 2020-02-06 18:52:00 PST
Created attachment 390043 [details]
Archive of layout-test-results from webkit-cq-03 for mac-mojave

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-mojave  Platform: Mac OS X 10.14.6
Comment 6 Alex Christensen 2020-02-14 10:21:23 PST
I'm allowing errors for uidna_nameToUnicode, not uidna_nameToASCII.  That fixes the test.
Comment 7 Alex Christensen 2020-02-14 10:21:55 PST
Created attachment 390783 [details]
Patch
Comment 8 WebKit Commit Bot 2020-02-14 11:09:38 PST
Comment on attachment 390783 [details]
Patch

Clearing flags on attachment: 390783

Committed r256629: <https://trac.webkit.org/changeset/256629>
Comment 9 WebKit Commit Bot 2020-02-14 11:09:39 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2020-02-14 11:10:20 PST
<rdar://problem/59465075>