Bug 207356

Summary: [JSC] CodeBlock::shrinkToFit should shrink m_constantRegisters and m_constantsSourceCodeRepresentation in 64bit architectures
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 207369    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch mark.lam: review+

Yusuke Suzuki
Reported 2020-02-06 14:35:44 PST
[JSC] CodeBlock::shrinkToFit should shrink m_constantRegisters and m_constantsSourceCodeRepresentation in 64bit architectures
Attachments
Patch (11.42 KB, patch)
2020-02-06 14:37 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (11.60 KB, patch)
2020-02-06 14:40 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-02-06 14:37:45 PST
Created attachment 389999 [details] Patch
Yusuke Suzuki
Comment 2 2020-02-06 14:40:40 PST
Created attachment 390001 [details] Patch
Mark Lam
Comment 3 2020-02-06 15:15:15 PST
Comment on attachment 390001 [details] Patch r=me
Yusuke Suzuki
Comment 4 2020-02-06 15:25:06 PST
Committed r255987: <https://trac.webkit.org/changeset/255987>
Radar WebKit Bug Importer
Comment 5 2020-02-06 15:26:16 PST
<rdar://problem/59239933>
Ryan Haddad
Comment 6 2020-02-06 17:24:08 PST
This appears to have caused layout tests to exit early due to excessive timeouts, and caused test262 to time out after 20m without output Layout tests: https://build.webkit.org/builders/Apple-Catalina-Release-WK2-Tests/builds/2755 test262: https://build.webkit.org/builders/Apple-Catalina-Debug-Test262-Tests/builds/855
WebKit Commit Bot
Comment 7 2020-02-06 17:25:23 PST
Re-opened since this is blocked by bug 207369
Yusuke Suzuki
Comment 8 2020-02-07 02:06:30 PST
Committed r256015: <https://trac.webkit.org/changeset/256015>
Note You need to log in before you can comment on or make changes to this bug.