Summary: | Filter out TURN/STUN .local URLs from a RTCPeerConnection iceServers list | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
youenn fablet
2020-02-06 06:56:52 PST
Created attachment 389956 [details]
Patch
Comment on attachment 389956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389956&action=review > Source/WebCore/ChangeLog:8 > + Filter out TURN/STUN .local URLs from a RTCPeerConnection iceServers list > + https://bugs.webkit.org/show_bug.cgi?id=207332 > + > + Reviewed by NOBODY (OOPS!). > + > + Test: webrtc/stun-server-filtering.html It would be nice to have a comment explaining why this change is necessary. Created attachment 390060 [details]
Patch for landing
Comment on attachment 390060 [details] Patch for landing Rejecting attachment 390060 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 390060, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/imported/w3c/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/13318463 Created attachment 390077 [details]
Patch for landing
Comment on attachment 390077 [details] Patch for landing Clearing flags on attachment: 390077 Committed r256024: <https://trac.webkit.org/changeset/256024> All reviewed patches have been landed. Closing bug. |