Bug 207304

Summary: resulsdbpy: Fix unit tests
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201928
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2020-02-05 15:40:00 PST
We have a few broken unit tests when using actual Cassandra (I tend to avoid running these tests because they are much more expensive then the mock versions)
Attachments
Patch (8.07 KB, patch)
2020-02-05 15:51 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2020-02-05 15:51:13 PST
Created attachment 389891 [details] Patch
Jonathan Bedard
Comment 2 2020-02-05 15:52:35 PST
100% testing code, none of this is actually serving content on results.webkit.org
Aakash Jain
Comment 3 2020-02-05 15:57:54 PST
This reminds me that we should run these tests in EWS. <rdar://problem/55109441>
Jonathan Bedard
Comment 4 2020-02-05 16:01:51 PST
(In reply to Aakash Jain from comment #3) > This reminds me that we should run these tests in EWS. > <rdar://problem/55109441> Yes, I was going to do that next, actually. We need some Pip packages on our EWS machine for it.
WebKit Commit Bot
Comment 5 2020-02-05 17:13:52 PST
Comment on attachment 389891 [details] Patch Clearing flags on attachment: 389891 Committed r255883: <https://trac.webkit.org/changeset/255883>
WebKit Commit Bot
Comment 6 2020-02-05 17:13:54 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2020-02-05 17:14:16 PST
<rdar://problem/59208735>
Note You need to log in before you can comment on or make changes to this bug.