Bug 207231

Summary: Fix Mac CMake build
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, darin, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Description Alex Christensen 2020-02-04 14:57:48 PST 
Fix some bit rot.
Comment 1 Alex Christensen 2020-02-04 15:00:16 PST 
Created attachment 389715 [details]
patch
Comment 2 Alex Christensen 2020-02-04 15:36:37 PST 
http://trac.webkit.org/r255709
Comment 3 Radar WebKit Bug Importer 2020-02-04 15:37:19 PST 
<rdar://problem/59168617>
Comment 4 Ryan Haddad 2020-02-04 17:39:41 PST 
Internal build fix in https://trac.webkit.org/changeset/255779/webkit
Comment 5 Darin Adler 2020-02-04 18:19:48 PST 
Comment on attachment 389715 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389715&action=review

> Tools/MiniBrowser/mac/WK2BrowserWindowController.m:133
> +#if __has_feature(objc_arc)
>      __weak WKWebView *weakWebView = _webView;
> +#else
> +    WKWebView *weakWebView = _webView;
> +#endif

I don’t understand this at all. This file is not ARC-compatible; it has a [super dealloc] call and calls to the release method.

What’s the story here?