Bug 207227

Summary: Non-unified build fixes early February 2020 edition
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, benjamin, cdumez, cfleizach, cgarcia, clopez, cmarcelo, commit-queue, dbates, dmazzoni, don.olmstead, ews-watchlist, hi, jcraig, jdiggs, joepeck, keith_miller, mark.lam, msaboff, saam, samuel_white, tzagallo, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Adrian Perez
Reported 2020-02-04 14:21:44 PST
We'll keep having issues now and then until I get round to continue work on #206737 ¬_¬
Attachments
Patch (5.12 KB, patch)
2020-02-04 14:27 PST, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.12 KB, patch)
2020-02-04 15:26 PST, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2020-02-04 14:27:04 PST
Created attachment 389708 [details] Patch
Don Olmstead
Comment 2 2020-02-04 14:29:50 PST
Comment on attachment 389708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389708&action=review > Source/JavaScriptCore/ChangeLog:3 > + Non-unified build fixes early January 2020 edition We're in February
Adrian Perez
Comment 3 2020-02-04 14:32:06 PST
(In reply to Don Olmstead from comment #2) > Comment on attachment 389708 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=389708&action=review > > > Source/JavaScriptCore/ChangeLog:3 > > + Non-unified build fixes early January 2020 edition > > We're in February So true 🤦‍♂️️
Don Olmstead
Comment 4 2020-02-04 15:14:00 PST
Comment on attachment 389708 [details] Patch I feel like these build fixes can be unreviewed. Going to r+ cause its fine but cq- because the Changelogs have the previous title
Adrian Perez
Comment 5 2020-02-04 15:26:10 PST
Created attachment 389724 [details] Patch for landing
Adrian Perez
Comment 6 2020-02-04 15:27:21 PST
(In reply to Don Olmstead from comment #4) > Comment on attachment 389708 [details] > Patch > > I feel like these build fixes can be unreviewed. Going to r+ cause its fine > but cq- because the Changelogs have the previous title Sure, I will do them as unreviewed build fixes from now on unless there is something that I am not 100% sure about :) Thanks!
WebKit Commit Bot
Comment 7 2020-02-04 16:09:46 PST
Comment on attachment 389724 [details] Patch for landing Clearing flags on attachment: 389724 Committed r255711: <https://trac.webkit.org/changeset/255711>
WebKit Commit Bot
Comment 8 2020-02-04 16:09:48 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2020-02-04 16:10:19 PST
<rdar://problem/59170022>
Note You need to log in before you can comment on or make changes to this bug.