Bug 207194

Summary: REGRESSION: [ iOS wk2 ] fast/scrolling/ios/scroll-events-back-forward.html is flaky failing
Product: WebKit Reporter: Jason Lawrence <Lawrence.j>
Component: ScrollingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, ggaren, simon.fraser, thorton, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: iPhone / iPad   
OS: iOS 13   
Attachments:
Description Flags
Update Test Expectations
none
WIP Patch
none
Patch
wenson_hsieh: review+, commit-queue: commit-queue-
Update Test Expectations none

Description Jason Lawrence 2020-02-04 06:51:45 PST 
fast/scrolling/ios/scroll-events-back-forward.html

Description:
This test is flaky failing on iOS. It has a possible regression point of 255234.

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fscrolling%2Fios%2Fscroll-events-back-forward.html&platform=ios&limit=50000

Diff:
--- /Volumes/Data/slave/ipados-simulator-13-debug-tests-wk2/build/layout-test-results/fast/scrolling/ios/scroll-events-back-forward-expected.txt
+++ /Volumes/Data/slave/ipados-simulator-13-debug-tests-wk2/build/layout-test-results/fast/scrolling/ios/scroll-events-back-forward-actual.txt
@@ -5,7 +5,7 @@
 
 pageshow 0
 pageshow 1
-PASS scrollEventCount is 1
+FAIL scrollEventCount should be 1. Was 0.
 PASS successfullyParsed is true
 
 TEST COMPLETE
Comment 1 Radar WebKit Bug Importer 2020-02-04 06:52:11 PST 
<rdar://problem/59148073>
Comment 2 Jason Lawrence 2020-02-04 06:54:50 PST 
I am able to reproduce this issue with run-webkit-tests using iterations. It failed 5x in 951 runs.
Comment 3 Jason Lawrence 2020-02-04 07:12:51 PST 
Created attachment 389657 [details]
Update Test Expectations
Comment 4 Truitt Savell 2020-02-04 07:42:08 PST 
Comment on attachment 389657 [details]
Update Test Expectations

Clearing flags on attachment: 389657

Committed r255672: <https://trac.webkit.org/changeset/255672>
Comment 5 Alexey Proskuryakov 2020-02-04 09:04:15 PST 
I see a slightly earlier failure on 2019-11-08 on internal tests, but yes, it's clearly a regression around that date. The test never failed before that date, and became a frequent failure afterwards.

Given that the test uses a 10 ms timer that may race with events, this may be a bad test, but going from zero to many failures suggests something more substantial to me.
Comment 6 Chris Dumez 2020-02-05 08:49:34 PST 
Created attachment 389813 [details]
WIP Patch
Comment 7 Chris Dumez 2020-02-05 08:55:43 PST 
Created attachment 389814 [details]
Patch
Comment 8 WebKit Commit Bot 2020-02-05 10:05:06 PST 
Comment on attachment 389814 [details]
Patch

Rejecting attachment 389814 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 389814, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=389814&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=207194&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 389814 from bug 207194.
Fetching: https://bugs.webkit.org/attachment.cgi?id=389814
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Wenson Hsieh']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 4 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 1.
patching file LayoutTests/fast/scrolling/ios/scroll-events-back-forward-expected.txt
patching file LayoutTests/fast/scrolling/ios/scroll-events-back-forward.html
patching file LayoutTests/platform/ios-wk2/TestExpectations
Hunk #1 FAILED at 1373.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/ios-wk2/TestExpectations.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Wenson Hsieh']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 4 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 1.
patching file LayoutTests/fast/scrolling/ios/scroll-events-back-forward-expected.txt
patching file LayoutTests/fast/scrolling/ios/scroll-events-back-forward.html
patching file LayoutTests/platform/ios-wk2/TestExpectations
Hunk #1 FAILED at 1373.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/ios-wk2/TestExpectations.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Wenson Hsieh']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   f3e0ae51dfc..25a039e8ba7  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 255820 = f3e0ae51dfc689d072afbdcc9d1ea2e0f262d484
r255821 = 89a32102035c0a9464a9ffd164e294fd08d8505d
r255822 = 25a039e8ba7905db1ecd9e401a94d665cd89b198
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/13317079
Comment 9 Chris Dumez 2020-02-05 10:08:08 PST 
Committed r255825: <https://trac.webkit.org/changeset/255825>
Comment 10 Jason Lawrence 2020-02-06 08:14:13 PST 
Reopening to attach new patch.
Comment 11 Jason Lawrence 2020-02-06 08:14:14 PST 
Created attachment 389959 [details]
Update Test Expectations
Comment 12 Truitt Savell 2020-02-06 08:21:31 PST 
This was reopened in error