Bug 207192

Summary: Check for callback being null in Notification.requestPermission
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2020-02-04 02:06:56 PST
Check for callback being null in Notification.requestPermission
Attachments
Patch (3.24 KB, patch)
2020-02-04 02:09 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-02-04 02:07:26 PST
<rdar://problem/59130804>
youenn fablet
Comment 2 2020-02-04 02:09:25 PST
Created attachment 389644 [details] Patch
Chris Dumez
Comment 3 2020-02-04 08:07:59 PST
Comment on attachment 389644 [details] Patch r=me. Not in this patch but it would be good to update this method to return a Promise as well.
WebKit Commit Bot
Comment 4 2020-02-04 08:55:20 PST
Comment on attachment 389644 [details] Patch Clearing flags on attachment: 389644 Committed r255680: <https://trac.webkit.org/changeset/255680>
WebKit Commit Bot
Comment 5 2020-02-04 08:55:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.