Bug 207192 - Check for callback being null in Notification.requestPermission
Summary: Check for callback being null in Notification.requestPermission
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-04 02:06 PST by youenn fablet
Modified: 2020-02-04 08:55 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.24 KB, patch)
2020-02-04 02:09 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-02-04 02:06:56 PST 
Check for callback being null in Notification.requestPermission
Comment 1 youenn fablet 2020-02-04 02:07:26 PST 
<rdar://problem/59130804>
Comment 2 youenn fablet 2020-02-04 02:09:25 PST 
Created attachment 389644 [details]
Patch
Comment 3 Chris Dumez 2020-02-04 08:07:59 PST 
Comment on attachment 389644 [details]
Patch

r=me. Not in this patch but it would be good to update this method to return a Promise as well.
Comment 4 WebKit Commit Bot 2020-02-04 08:55:20 PST 
Comment on attachment 389644 [details]
Patch

Clearing flags on attachment: 389644

Committed r255680: <https://trac.webkit.org/changeset/255680>
Comment 5 WebKit Commit Bot 2020-02-04 08:55:22 PST 
All reviewed patches have been landed.  Closing bug.