Bug 207189

Summary: REGRESSION(r255595): page not closed after beforeunload handler returns true
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, commit-queue, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=207121
Bug Depends on: 208015    
Bug Blocks:    
Attachments:
Description Flags
Fix
none
API Test
none
API test none

Carlos Garcia Campos
Reported 2020-02-04 01:48:58 PST
We are assuming the try close did timeout in that case, because the timer is stopped before running the beforeunload dialog.
Attachments
Fix (1.99 KB, patch)
2020-02-04 01:52 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
API Test (3.89 KB, patch)
2020-02-04 08:40 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
API test (3.64 KB, patch)
2020-02-04 08:54 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2020-02-04 01:52:16 PST
Created attachment 389641 [details] Fix
Chris Dumez
Comment 2 2020-02-04 08:12:45 PST
Comment on attachment 389641 [details] Fix Should have a test but I will follow-up.
Chris Dumez
Comment 3 2020-02-04 08:17:47 PST
Comment on attachment 389641 [details] Fix Clearing flags on attachment: 389641 Committed r255677: <https://trac.webkit.org/changeset/255677>
Chris Dumez
Comment 4 2020-02-04 08:17:48 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2020-02-04 08:18:15 PST
<rdar://problem/59149593>
Chris Dumez
Comment 6 2020-02-04 08:38:57 PST
Reopening for API test.
Chris Dumez
Comment 7 2020-02-04 08:40:08 PST
Created attachment 389664 [details] API Test
Chris Dumez
Comment 8 2020-02-04 08:54:50 PST
Created attachment 389667 [details] API test
Chris Dumez
Comment 9 2020-02-05 09:08:16 PST
Comment on attachment 389667 [details] API test Ping review?
Chris Dumez
Comment 10 2020-02-05 10:08:59 PST
Comment on attachment 389667 [details] API test Clearing flags on attachment: 389667 Committed r255826: <https://trac.webkit.org/changeset/255826>
Chris Dumez
Comment 11 2020-02-05 10:09:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.