Bug 207172

Summary: [JSC] Use PackedPtr for VariableEnvironment
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Yusuke Suzuki
Reported 2020-02-03 17:53:18 PST
[JSC] Use PackedCellPtr for VariableEnvironment
Attachments
Patch (5.29 KB, patch)
2020-02-03 17:54 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-02-03 17:54:10 PST
Created attachment 389608 [details] Patch
Mark Lam
Comment 2 2020-02-03 18:05:47 PST
Comment on attachment 389608 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389608&action=review r=me > Source/JavaScriptCore/ChangeLog:13 > + * runtime/CachedTypes.cpp: > + (JSC::CachedRefPtr::encode): > + (JSC::CachedRefPtr::decode const): Your ChangeLog and title doesn't seem to include changes in CachedTypes. Is this intended to be part of this patch? If so, can you add a small blurb in the ChangeLog or update the title?
Yusuke Suzuki
Comment 3 2020-02-03 20:16:59 PST
Comment on attachment 389608 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389608&action=review >> Source/JavaScriptCore/ChangeLog:13 >> + (JSC::CachedRefPtr::decode const): > > Your ChangeLog and title doesn't seem to include changes in CachedTypes. Is this intended to be part of this patch? If so, can you add a small blurb in the ChangeLog or update the title? Fixed. This is just because CachedTypes should handle PackedPtr since changed data structures are encoded.
Yusuke Suzuki
Comment 4 2020-02-03 20:22:36 PST
Committed r255659: <https://trac.webkit.org/changeset/255659>
Radar WebKit Bug Importer
Comment 5 2020-02-03 20:23:15 PST
<rdar://problem/59137576>
Note You need to log in before you can comment on or make changes to this bug.