Bug 20714

Summary:

Resizing Gmail inbox vertically results in whitespace at the bottom of the window (caused by a CSS error)

Product:

WebKit

Reporter:

Darin Fisher (:fishd, Google) <fishd>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, hyatt, mitz

Priority:

Keywords:

GoogleBug, HasReduction, InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

URL:

http://mail.google.com/

Attachments:

Description	Flags
reduction	none
reduction: frame source (click the other one)	none
reduction: top frame source (click on me)	none
Reduction	none
Correct reduction	none
Patch for this bug and bug 15384	hyatt: review+

Darin Fisher (:fishd, Google)

Reported 2008-09-08 01:02:16 PDT

Resizing Gmail inbox vertically results in whitespace at the bottom of the window (caused by a CSS error). NOTE: if you resize horizontally, then this problem does not exist. See the reduction that I am about to post.

Attachments
reduction (304 bytes, text/html) 2008-09-08 01:03 PDT, Darin Fisher (:fishd, Google)	no flags	Details
reduction: frame source (click the other one) (324 bytes, text/html) 2008-09-08 01:07 PDT, Darin Fisher (:fishd, Google)	no flags	Details
reduction: top frame source (click on me) (374 bytes, text/html) 2008-09-08 01:08 PDT, Darin Fisher (:fishd, Google)	no flags	Details
Reduction (549 bytes, text/html) 2008-09-08 07:28 PDT, mitz	no flags	Details
Correct reduction (559 bytes, text/html) 2008-09-15 17:29 PDT, mitz	no flags	Details
Patch for this bug and bug 15384 (45.50 KB, patch) 2008-09-15 18:32 PDT, mitz	hyatt: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Darin Fisher (:fishd, Google)

Comment 1 2008-09-08 01:03:02 PDT

Created attachment 23241 [details] reduction

Darin Fisher (:fishd, Google)

Comment 2 2008-09-08 01:04:17 PDT

Comment on attachment 23241 [details] reduction oops.. let me try that again.

Darin Fisher (:fishd, Google)

Comment 3 2008-09-08 01:07:01 PDT

Created attachment 23242 [details] reduction: frame source (click the other one)

Darin Fisher (:fishd, Google)

Comment 4 2008-09-08 01:08:42 PDT

Created attachment 23243 [details] reduction: top frame source (click on me)

Darin Fisher (:fishd, Google)

Comment 5 2008-09-08 01:11:05 PDT

If you open attachment 23243 [details], and then resize the window in the vertical direction, increasing the size of the window, you should notice that it does not paint the background properly.

Maciej Stachowiak

Comment 6 2008-09-08 01:13:34 PDT

FWIW this is reproducible on Mac as well, but you have to be careful to resize vertical only. You get a white stripe at the bottom. If you resize horizontally even a little the problem fixes itself.

mitz

Comment 7 2008-09-08 07:26:49 PDT

<rdar://problem/5985669>

mitz

Comment 8 2008-09-08 07:28:29 PDT

Created attachment 23257 [details] Reduction

mitz

Comment 9 2008-09-08 07:31:37 PDT

Might need to do something similar to the WIP patch attached to bug 15384.

mitz

Comment 10 2008-09-15 17:29:40 PDT

Created attachment 23451 [details] Correct reduction While behavior with attachment 23257 [details] is buggy, it does not reflect what happens on Gmail.

mitz

Comment 11 2008-09-15 18:32:17 PDT

Created attachment 23455 [details] Patch for this bug and bug 15384 I did try something simpler to address this bug alone (without bug 15384), which was basically for layoutBlockChildren() to always look at grandchildren of anonymous blocks and see if any of them had percentage heights. That code got hit quite frequently, so I think this might be a better solution.

Dave Hyatt

Comment 12 2008-09-15 22:44:10 PDT

Comment on attachment 23455 [details] Patch for this bug and bug 15384 r=me, assuming you are confident it's not a performance regression.

mitz

Comment 13 2008-09-16 10:34:42 PDT

Fixed in <http://trac.webkit.org/changeset/36513>.

Note You need to log in before you can comment on or make changes to this bug.