Bug 207122

Summary: NetworkProcess should be notified by UIProcess when its service worker process connection should be on
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2020-02-03 08:58:44 PST
NetworkProcess should be notified by UIProcess when its service worker process connection should be on
Attachments
Patch (24.13 KB, patch)
2020-02-03 09:10 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (26.21 KB, patch)
2020-02-04 03:51 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (27.22 KB, patch)
2020-02-04 04:53 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-02-03 09:09:19 PST
<rdar://problem/59089780>
youenn fablet
Comment 2 2020-02-03 09:10:14 PST
Created attachment 389523 [details] Patch
youenn fablet
Comment 3 2020-02-04 03:51:04 PST
Created attachment 389649 [details] Patch
youenn fablet
Comment 4 2020-02-04 04:53:13 PST
Created attachment 389650 [details] Patch
youenn fablet
Comment 5 2020-02-04 07:20:53 PST
<rdar://problem/58850406>
WebKit Commit Bot
Comment 6 2020-02-04 09:02:11 PST
Comment on attachment 389650 [details] Patch Clearing flags on attachment: 389650 Committed r255681: <https://trac.webkit.org/changeset/255681>
WebKit Commit Bot
Comment 7 2020-02-04 09:02:13 PST
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 8 2020-02-04 09:24:15 PST
Comment on attachment 389650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389650&action=review > Source/WebKit/UIProcess/WebProcessProxy.cpp:1610 > + sendWithAsyncReply(Messages::WebProcess::EstablishWorkerContextConnectionToNetworkProcess { processPool().defaultPageGroup().pageGroupID(), m_serviceWorkerInformation->serviceWorkerPageProxyID, m_serviceWorkerInformation->serviceWorkerPageID, store, *m_registrableDomain, m_serviceWorkerInformation->initializationData }, [activity = m_throttler.backgroundActivity("Establish Service Worker"_s), completionHandler = WTFMove(completionHandler)]() mutable { BTW, I think it is a great fix to take a background activity here. I had identified this as an issue locally and was about to upload a patch to fix this. Previously, the service worker process could suspend *before* having finished initialization and setup a connection to the network process. I am hoping this will address the flakiness issues on the bots.
Note You need to log in before you can comment on or make changes to this bug.