Bug 20712

Summary: Remove JSC_FAST_CALL if it is not a performance regression
Product: WebKit Reporter: Cameron Zwarich (cpst) <zwarich>
Component: JavaScriptCoreAssignee: Cameron Zwarich (cpst) <zwarich>
Status: RESOLVED FIXED    
Severity: Normal CC: xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch
none
SunSpider results for last patch against r36264 none

Cameron Zwarich (cpst)
Reported 2008-09-07 22:32:51 PDT
Now that we only traverse the AST for bytecode generation and printing, the JSC_FAST_CALL intrinsic is likely unnecessary. We should remove it if it is not a performance regression.
Attachments
Proposed patch (114.83 KB, text/plain)
2008-09-07 22:35 PDT, Cameron Zwarich (cpst) 		no flags
Details
SunSpider results for last patch against r36264 (3.69 KB, text/plain)
2008-09-07 22:37 PDT, Cameron Zwarich (cpst) 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Cameron Zwarich (cpst)
Comment 1 2008-09-07 22:35:49 PDT
Created attachment 23239 [details] Proposed patch
Cameron Zwarich (cpst)
Comment 2 2008-09-07 22:37:03 PDT
Created attachment 23240 [details] SunSpider results for last patch against r36264
Cameron Zwarich (cpst)
Comment 3 2008-09-07 22:44:19 PDT
Comment on attachment 23239 [details] Proposed patch Oliver pointed out that I should test the V8 benchmark suite and non-JIT build configurations.
Xan Lopez
Comment 4 2010-11-01 19:32:08 PDT
This happened in August 2009, so we can close the bug.
Note You need to log in before you can comment on or make changes to this bug.