Bug 207065

Summary: Add support for specifying background colors when setting marked text
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bdakin, commit-queue, dbates, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, megan_gardner, mifenton, mmaxfield, pdr, rniwa, ryuan.choi, sergio, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix GTK build
thorton: review+
Patch for EWS none

Description Wenson Hsieh 2020-01-31 12:48:57 PST 
Allow clients to highlight ranges in marked text.
Comment 1 Wenson Hsieh 2020-01-31 12:49:14 PST 
<rdar://problem/57876140>
Comment 2 Wenson Hsieh 2020-01-31 13:35:39 PST Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2020-01-31 13:45:07 PST 
Created attachment 389406 [details]
Fix GTK build
Comment 4 Tim Horton 2020-01-31 14:01:02 PST 
Comment on attachment 389406 [details]
Fix GTK build

View in context: https://bugs.webkit.org/attachment.cgi?id=389406&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4535
> +        unsigned location = range.location;

why the local?
Comment 5 Wenson Hsieh 2020-01-31 14:01:47 PST 
Comment on attachment 389406 [details]
Fix GTK build

View in context: https://bugs.webkit.org/attachment.cgi?id=389406&action=review

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4535
>> +        unsigned location = range.location;
> 
> why the local?

Whoops, no reason! Removed.
Comment 6 Wenson Hsieh 2020-01-31 14:56:25 PST 
Created attachment 389421 [details]
Patch for EWS
Comment 7 WebKit Commit Bot 2020-01-31 16:44:15 PST 
Comment on attachment 389421 [details]
Patch for EWS

Clearing flags on attachment: 389421

Committed r255532: <https://trac.webkit.org/changeset/255532>