Bug 207065

Summary: Add support for specifying background colors when setting marked text
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bdakin, commit-queue, dbates, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, megan_gardner, mifenton, mmaxfield, pdr, rniwa, ryuan.choi, sergio, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix GTK build
thorton: review+
Patch for EWS none

Wenson Hsieh
Reported 2020-01-31 12:48:57 PST
Allow clients to highlight ranges in marked text.
Attachments
Patch (57.70 KB, patch)
2020-01-31 13:35 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix GTK build (58.24 KB, patch)
2020-01-31 13:45 PST, Wenson Hsieh 		thorton: review+
DetailsFormatted DiffDiff
Patch for EWS (58.17 KB, patch)
2020-01-31 14:56 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-01-31 12:49:14 PST
<rdar://problem/57876140>
Wenson Hsieh
Comment 2 2020-01-31 13:35:39 PST Comment hidden (obsolete)
Wenson Hsieh
Comment 3 2020-01-31 13:45:07 PST
Created attachment 389406 [details] Fix GTK build
Tim Horton
Comment 4 2020-01-31 14:01:02 PST
Comment on attachment 389406 [details] Fix GTK build View in context: https://bugs.webkit.org/attachment.cgi?id=389406&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4535 > + unsigned location = range.location; why the local?
Wenson Hsieh
Comment 5 2020-01-31 14:01:47 PST
Comment on attachment 389406 [details] Fix GTK build View in context: https://bugs.webkit.org/attachment.cgi?id=389406&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4535 >> + unsigned location = range.location; > > why the local? Whoops, no reason! Removed.
Wenson Hsieh
Comment 6 2020-01-31 14:56:25 PST
Created attachment 389421 [details] Patch for EWS
WebKit Commit Bot
Comment 7 2020-01-31 16:44:15 PST
Comment on attachment 389421 [details] Patch for EWS Clearing flags on attachment: 389421 Committed r255532: <https://trac.webkit.org/changeset/255532>
Note You need to log in before you can comment on or make changes to this bug.