Bug 207052

Summary: REGRESSION (r251511): [iOS] HDR Playback broken
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, eric.carlson, jer.noble, mjs, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mjs: review+

Brent Fulgham
Reported 2020-01-31 09:38:01 PST
I missed an XPC service in Bug 203318 when I stopped importing the 'common.sb' sandbox so that we could use tighter rules. This broke some aspects of HDR playback for certain clients. I also noticed a preference file that is needed by AVF code, so I'm unblocking that as well.
Attachments
Patch (3.81 KB, patch)
2020-01-31 09:45 PST, Brent Fulgham 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2020-01-31 09:38:34 PST
<rdar://problem/58975614>
Brent Fulgham
Comment 2 2020-01-31 09:45:52 PST
Created attachment 389365 [details] Patch
Maciej Stachowiak
Comment 3 2020-01-31 09:51:32 PST
Comment on attachment 389365 [details] Patch r=me
Brent Fulgham
Comment 4 2020-01-31 09:54:31 PST
Committed r255503: <https://trac.webkit.org/changeset/255503>
Per Arne Vollan
Comment 5 2020-01-31 10:08:27 PST
Comment on attachment 389365 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389365&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:146 > + (global-name "com.apple.coremedia.cpe.xpc") ; Needed for HDR playback. It does not seem like this service is part of common.sb. Maybe it is sufficient with the preference changes to fix this bug?
Note You need to log in before you can comment on or make changes to this bug.