Summary: | [ews] Set custom build summary for webkitpy tests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, ap, commit-queue, jbedard, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 207026 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Aakash Jain
2020-01-30 19:20:17 PST
Created attachment 389326 [details]
Patch
Sample runs: https://ews-build.webkit-uat.org/#/builders/8/builds/102 https://ews-build.webkit-uat.org/#/builders/8/builds/103 'services' ews failure is because this patch is dependent on patch in Bug 207026. (In reply to Aakash Jain from comment #3) > 'services' ews failure is because this patch is dependent on patch in Bug > 207026. Let's wait for https://bugs.webkit.org/show_bug.cgi?id=207026 to land so we can have green EWS before landing. (In reply to Jonathan Bedard from comment #4) > Let's wait for https://bugs.webkit.org/show_bug.cgi?id=207026 to land so we can have green EWS before landing. Done. 'services' and 'style' bubbles are green now. win, ios-wk2 are flaky failures. Comment on attachment 389326 [details]
Patch
Code looks good, but I'd like to see the example where Python 2 fails but Python 3 does not
> I'd like to see the example where Python 2 fails but Python 3 does not https://ews-build.webkit-uat.org/#/builders/8/builds/142 Comment on attachment 389326 [details] Patch Clearing flags on attachment: 389326 Committed r255580: <https://trac.webkit.org/changeset/255580> All reviewed patches have been landed. Closing bug. |