Bug 207005

Summary: [CMake] Add SQLite::SQLite3 target
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, don.olmstead, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Ross Kirsling
Reported 2020-01-30 09:54:17 PST
[CMake] Add SQLite::SQLite3 target
Attachments
Patch (12.49 KB, patch)
2020-01-30 09:57 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (13.37 KB, patch)
2020-01-30 11:44 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (13.36 KB, patch)
2020-01-30 14:02 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2020-01-30 09:57:36 PST
Created attachment 389260 [details] Patch
Don Olmstead
Comment 2 2020-01-30 10:00:03 PST
Comment on attachment 389260 [details] Patch r=me Just wait for the bots.
Ross Kirsling
Comment 3 2020-01-30 11:44:58 PST
Created attachment 389273 [details] Patch
Don Olmstead
Comment 4 2020-01-30 13:55:33 PST
Comment on attachment 389273 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389273&action=review > Source/cmake/OptionsAppleWin.cmake:13 > +find_package(SQLite3 3.23.1 REQUIRED) Just make it REQUIRED without the version like OptionsGTK does. The one AppleWin is using is ancient.
Ross Kirsling
Comment 5 2020-01-30 14:02:52 PST
Created attachment 389285 [details] Patch
WebKit Commit Bot
Comment 6 2020-01-30 16:52:04 PST
Comment on attachment 389285 [details] Patch Clearing flags on attachment: 389285 Committed r255475: <https://trac.webkit.org/changeset/255475>
WebKit Commit Bot
Comment 7 2020-01-30 16:52:06 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-01-30 16:53:16 PST
<rdar://problem/59047569>
Note You need to log in before you can comment on or make changes to this bug.