Bug 206992

Summary:

Regression: http/tests/loading/remove-child-triggers-parser.html is failing consistently on windows

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, bfulgham, cdumez, pvollan, rniwa, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes the test	simon.fraser: review+

Description Aakash Jain 2020-01-30 04:34:49 PST

Regression: http/tests/loading/remove-child-triggers-parser.html is failing consistently on windows.

Sample results:
- https://build.webkit.org/results/Apple%20Win%2010%20Release%20(Tests)/r255258%20(4756)/results.html
- https://ews-build.webkit.org/results/Windows-EWS/r389236-5875-clean-tree/results.html


Results database: https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Floading%2Fremove-child-triggers-parser.html

Regression range: r255188 - r255258.

Comment 1 Aakash Jain 2020-01-30 04:35:07 PST

Diff:

--- /home/buildbot/worker/Windows-EWS/build/layout-test-results/http/tests/loading/remove-child-triggers-parser-expected.txt
+++ /home/buildbot/worker/Windows-EWS/build/layout-test-results/http/tests/loading/remove-child-triggers-parser-actual.txt
@@ -3,3 +3,4 @@
 main frame - didFinishDocumentLoadForFrame
 main frame - didHandleOnloadEventsForFrame
 main frame - didFinishLoadForFrame
+ERROR: nil result from IDOMElement::innerText

Comment 2 Aakash Jain 2020-01-30 04:37:32 PST

Possible regression point: r255223 (Bug 103115:http/tests/loading/remove-child-triggers-parser.html is flaky)

Comment 3 Radar WebKit Bug Importer 2020-01-30 04:37:55 PST

<rdar://problem/59025071>

Comment 4 Ryosuke Niwa 2020-01-30 14:47:49 PST

Huh, I guess IDOMElement::innerText doesn't like the fact there is no document element anymore. I guess we'd work around that in the test itself.

Comment 5 Ryosuke Niwa 2020-01-30 18:19:58 PST

Created attachment 389324 [details]
Fixes the test

Comment 6 Ryosuke Niwa 2020-01-30 18:27:06 PST

Committed r255481: <https://trac.webkit.org/changeset/255481>

Comment 7 Ryosuke Niwa 2020-03-03 21:17:45 PST

This test appears to be passing now.