Bug 206919

Summary: macCatalyst: Right clicking on a link follows it immediately
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Tim Horton 2020-01-28 21:57:38 PST 
macCatalyst: Right clicking on a link follows it immediately
Comment 1 Tim Horton 2020-01-28 21:57:58 PST 
Created attachment 389105 [details]
Patch
Comment 2 Tim Horton 2020-01-28 21:58:00 PST 
<rdar://problem/58936679>
Comment 3 Tim Horton 2020-01-28 21:59:17 PST 
Created attachment 389106 [details]
Patch
Comment 4 Wenson Hsieh 2020-01-28 22:01:40 PST 
Comment on attachment 389106 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389106&action=review

> Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm:177
> +    _pressedButtonMask = WTF::nullopt;

Should we clear this out in -touchesCancelled:withEvent: as well?
Comment 5 Wenson Hsieh 2020-01-28 22:03:19 PST 
Comment on attachment 389106 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389106&action=review

>> Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm:177
>> +    _pressedButtonMask = WTF::nullopt;
> 
> Should we clear this out in -touchesCancelled:withEvent: as well?

Never mind, -touchesCancelled:withEvent: calls -touchesEnded:withEvent: anyways. 😅
Comment 6 WebKit Commit Bot 2020-01-28 22:46:58 PST 
Comment on attachment 389106 [details]
Patch

Clearing flags on attachment: 389106

Committed r255337: <https://trac.webkit.org/changeset/255337>
Comment 7 WebKit Commit Bot 2020-01-28 22:47:00 PST 
All reviewed patches have been landed.  Closing bug.