Bug 206919

Summary: macCatalyst: Right clicking on a link follows it immediately
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2020-01-28 21:57:38 PST
macCatalyst: Right clicking on a link follows it immediately
Attachments
Patch (6.00 KB, patch)
2020-01-28 21:57 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (8.33 KB, patch)
2020-01-28 21:59 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2020-01-28 21:57:58 PST
Created attachment 389105 [details] Patch
Tim Horton
Comment 2 2020-01-28 21:58:00 PST
<rdar://problem/58936679>
Tim Horton
Comment 3 2020-01-28 21:59:17 PST
Created attachment 389106 [details] Patch
Wenson Hsieh
Comment 4 2020-01-28 22:01:40 PST
Comment on attachment 389106 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389106&action=review > Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm:177 > + _pressedButtonMask = WTF::nullopt; Should we clear this out in -touchesCancelled:withEvent: as well?
Wenson Hsieh
Comment 5 2020-01-28 22:03:19 PST
Comment on attachment 389106 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389106&action=review >> Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm:177 >> + _pressedButtonMask = WTF::nullopt; > > Should we clear this out in -touchesCancelled:withEvent: as well? Never mind, -touchesCancelled:withEvent: calls -touchesEnded:withEvent: anyways. 😅
WebKit Commit Bot
Comment 6 2020-01-28 22:46:58 PST
Comment on attachment 389106 [details] Patch Clearing flags on attachment: 389106 Committed r255337: <https://trac.webkit.org/changeset/255337>
WebKit Commit Bot
Comment 7 2020-01-28 22:47:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.