Bug 206913

Summary: TestWebKitAPI: Conditionalize device orientation tests on ENABLE(DEVICE_ORIENTATION)
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2020-01-28 15:56:05 PST
It doesn't make sense to attempt to run device orientation tests when on a platform that has DEVICE_ORIENTATION disabled.
Attachments
Patch (1.09 KB, patch)
2020-01-28 15:58 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.34 KB, patch)
2020-01-28 16:13 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-01-28 15:56:52 PST
<rdar://problem/58973357>
Jonathan Bedard
Comment 2 2020-01-28 15:58:27 PST
Created attachment 389082 [details] Patch
Chris Dumez
Comment 3 2020-01-28 16:06:16 PST
Comment on attachment 389082 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389082&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:28 > +#if ENABLE(DEVICE_ORIENTATION) && PLATFORM(IOS_FAMILY) Please update this comment at the end of the file as well: #endif // PLATFORM(IOS_FAMILY)
Jonathan Bedard
Comment 4 2020-01-28 16:13:05 PST
Created attachment 389084 [details] Patch for landing
WebKit Commit Bot
Comment 5 2020-01-28 16:55:28 PST
Comment on attachment 389084 [details] Patch for landing Clearing flags on attachment: 389084 Committed r255328: <https://trac.webkit.org/changeset/255328>
WebKit Commit Bot
Comment 6 2020-01-28 16:55:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.