Bug 206910

Summary: [iOS][WK2] Drop process assertion logic for holding locked files
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, ggaren, sihui_liu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 213194    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2020-01-28 14:45:43 PST
Drop process assertion logic for holding locked files as it is causing issues and should no longer be needed.
Attachments
Patch (22.83 KB, patch)
2020-01-28 14:53 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (24.07 KB, patch)
2020-01-28 15:03 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (25.55 KB, patch)
2020-01-28 15:19 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (25.10 KB, patch)
2020-04-28 09:32 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (25.39 KB, patch)
2020-04-28 09:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-01-28 14:53:32 PST
Created attachment 389068 [details] Patch
Chris Dumez
Comment 2 2020-01-28 15:03:09 PST
Created attachment 389071 [details] Patch
Chris Dumez
Comment 3 2020-01-28 15:19:13 PST
Created attachment 389074 [details] Patch
Chris Dumez
Comment 4 2020-02-20 09:17:02 PST
Comment on attachment 389074 [details] Patch Will investigate iOS api test failures.
Sihui Liu
Comment 5 2020-02-20 09:53:47 PST
Comment on attachment 389074 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389074&action=review > Source/WebKit/ChangeLog:22 > + those processes will make sure to suspend their database threads to prevent any I remember further database work would be stopped only when the suspension is imminent or there is no ongoing transaction. If the concept of imminent suspension is still there, we need to also set IsSuspensionImminent::Yes, or set ShouldForceStop::No in WebIDBServer::suspend. A nice thing about having the logic is we don't force aborting ongoing transaction if we know a message of holding file lock has been sent.
Chris Dumez
Comment 6 2020-04-28 09:32:22 PDT
Created attachment 397845 [details] Patch
Chris Dumez
Comment 7 2020-04-28 09:38:51 PDT
Created attachment 397846 [details] Patch
EWS
Comment 8 2020-04-28 17:03:27 PDT
Committed r260856: <https://trac.webkit.org/changeset/260856> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397846 [details].
Radar WebKit Bug Importer
Comment 9 2020-04-28 17:10:45 PDT
<rdar://problem/62558526>
Alexey Proskuryakov
Comment 10 2020-06-15 15:41:06 PDT
Looks like this got reverted, but the bug is still RESOLVED/FIXED.
Note You need to log in before you can comment on or make changes to this bug.