Bug 206810

Summary: [LFC][IFC] Display::Run has physical geometry only.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

alan
Reported 2020-01-26 14:49:29 PST
ssia
Attachments
Patch (20.01 KB, patch)
2020-01-26 14:57 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (20.00 KB, patch)
2020-01-26 17:50 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (21.30 KB, patch)
2020-01-27 06:39 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-01-26 14:49:46 PST
<rdar://problem/58905455>
alan
Comment 2 2020-01-26 14:57:39 PST
Created attachment 388816 [details] Patch
alan
Comment 3 2020-01-26 17:50:22 PST
Created attachment 388820 [details] Patch
Antti Koivisto
Comment 4 2020-01-27 02:09:55 PST
Comment on attachment 388820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388820&action=review > Source/WebCore/rendering/line/LineLayoutTraversalDisplayRunPath.h:-54 > - FloatRect logicalRect() const You can also remove this from SimplePath and ComplexPath.
alan
Comment 5 2020-01-27 06:35:22 PST
(In reply to Antti Koivisto from comment #4) > Comment on attachment 388820 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388820&action=review > > > Source/WebCore/rendering/line/LineLayoutTraversalDisplayRunPath.h:-54 > > - FloatRect logicalRect() const > > You can also remove this from SimplePath and ComplexPath. good point!
alan
Comment 6 2020-01-27 06:39:10 PST
Created attachment 388853 [details] Patch
WebKit Commit Bot
Comment 7 2020-01-27 07:25:38 PST
Comment on attachment 388853 [details] Patch Clearing flags on attachment: 388853 Committed r255143: <https://trac.webkit.org/changeset/255143>
WebKit Commit Bot
Comment 8 2020-01-27 07:25:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.