Bug 206810 - [LFC][IFC] Display::Run has physical geometry only.
Summary: [LFC][IFC] Display::Run has physical geometry only.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-26 14:49 PST by zalan
Modified: 2020-01-27 07:25 PST (History)
11 users (show)

See Also:

Attachments
Patch (20.01 KB, patch)
2020-01-26 14:57 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (20.00 KB, patch)
2020-01-26 17:50 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (21.30 KB, patch)
2020-01-27 06:39 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-01-26 14:49:29 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2020-01-26 14:49:46 PST 
<rdar://problem/58905455>
Comment 2 zalan 2020-01-26 14:57:39 PST 
Created attachment 388816 [details]
Patch
Comment 3 zalan 2020-01-26 17:50:22 PST 
Created attachment 388820 [details]
Patch
Comment 4 Antti Koivisto 2020-01-27 02:09:55 PST 
Comment on attachment 388820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388820&action=review

> Source/WebCore/rendering/line/LineLayoutTraversalDisplayRunPath.h:-54
> -    FloatRect logicalRect() const

You can also remove this from SimplePath and ComplexPath.
Comment 5 zalan 2020-01-27 06:35:22 PST 
(In reply to Antti Koivisto from comment #4)
> Comment on attachment 388820 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388820&action=review
> 
> > Source/WebCore/rendering/line/LineLayoutTraversalDisplayRunPath.h:-54
> > -    FloatRect logicalRect() const
> 
> You can also remove this from SimplePath and ComplexPath.

good point!
Comment 6 zalan 2020-01-27 06:39:10 PST 
Created attachment 388853 [details]
Patch
Comment 7 WebKit Commit Bot 2020-01-27 07:25:38 PST 
Comment on attachment 388853 [details]
Patch

Clearing flags on attachment: 388853

Committed r255143: <https://trac.webkit.org/changeset/255143>
Comment 8 WebKit Commit Bot 2020-01-27 07:25:40 PST 
All reviewed patches have been landed.  Closing bug.