Summary: | [ews] Status bubble hover over message in case of success should indicate whether it built the patch or run tests | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, ap, jbedard, jer.noble, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=201253 | ||||||||
Attachments: |
|
Description
Aakash Jain
2020-01-26 06:24:18 PST
Created attachment 388801 [details]
Patch
Created attachment 388802 [details]
Screenshot of hover over messages
Comment on attachment 388801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388801&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:125 > + bubble['details_message'] = 'Pass' Not convinced this is the best UI for Perl and Python tests, but it's definitely an improvement for webkit queues. Comment on attachment 388801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388801&action=review >> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:125 >> + bubble['details_message'] = 'Pass' > > Not convinced this is the best UI for Perl and Python tests, but it's definitely an improvement for webkit queues. This 'else' is just a fallback and wouldn't be hit with any of current queues. Perl and Python tests will also say 'Passed tests'. Committed r255157: <https://trac.webkit.org/changeset/255157> Deployed on the production server. |