Bug 206807

Summary:

[ews] Status bubble hover over message in case of success should indicate whether it built the patch or run tests

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, jbedard, jer.noble, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=201253

Attachments:

Description	Flags
Patch	none
Screenshot of hover over messages	none

Aakash Jain

Reported 2020-01-26 06:24:18 PST

Currently for every green status bubble the hover over message is generic and simply says: "Pass". This doesn't indicate whether the queue built the patch, run the tests, or did both. We should change the generic message to more specific like: 'Built successfully', 'Passed tests' or 'Built successfully and passed tests'. Note that we already have emojis in the status-bubbles indicating whether the queue is builder or tester or both (added in https://trac.webkit.org/changeset/249483/webkit). However, one user provided feedback that he did not paid attention to the emojis and was confused whether the queue was builder or tester. This change (hover-over text) would provide additional feedback about the queue being builder or tester or both.

Attachments
Patch (2.65 KB, patch) 2020-01-26 06:26 PST, Aakash Jain	no flags	Details Formatted Diff Diff
Screenshot of hover over messages (782.28 KB, image/png) 2020-01-26 06:36 PST, Aakash Jain	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-01-26 06:24:54 PST

<rdar://problem/58901538>

Aakash Jain

Comment 2 2020-01-26 06:26:54 PST

Created attachment 388801 [details] Patch

Aakash Jain

Comment 3 2020-01-26 06:36:02 PST

Created attachment 388802 [details] Screenshot of hover over messages

Jonathan Bedard

Comment 4 2020-01-27 09:53:20 PST

Comment on attachment 388801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388801&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:125 > + bubble['details_message'] = 'Pass' Not convinced this is the best UI for Perl and Python tests, but it's definitely an improvement for webkit queues.

Aakash Jain

Comment 5 2020-01-27 10:28:48 PST

Comment on attachment 388801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388801&action=review >> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:125 >> + bubble['details_message'] = 'Pass' > > Not convinced this is the best UI for Perl and Python tests, but it's definitely an improvement for webkit queues. This 'else' is just a fallback and wouldn't be hit with any of current queues. Perl and Python tests will also say 'Passed tests'.

Aakash Jain

Comment 6 2020-01-27 11:33:09 PST

Committed r255157: <https://trac.webkit.org/changeset/255157>

Aakash Jain

Comment 7 2020-01-27 17:49:28 PST

Deployed on the production server.

Note You need to log in before you can comment on or make changes to this bug.