Bug 206794
| Summary: | REGRESSION(2.28): [GTK] WPE implementation of show-option-menu breaks the GTK binding | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | bugs-noreply, cgarcia, mcatanzaro |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=206287 | ||
| Bug Depends on: | |||
| Bug Blocks: | 210100 | ||
Michael Catanzaro
[84/87] Generating ../../WebKit2-4.0.gir
../../../../../../Projects/WebKit/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:2137: Warning: WebKit2: multiple comment blocks documenting 'WebKitWebView::show-option-menu:' identifier (already seen at WebKitWebView.cpp:2101).
../../../../../../Projects/WebKit/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:2137: Warning: WebKit2: incorrect number of parameters in comment block, parameter annotations will be ignored.
The problem is that introspection scanner doesn't respect #if PLATFORM(WPE).
I tried adding #ifndef __GI_SCANNER__ but that didn't work. I think it's going to require adding a platformClassInit() call in order to split the WPE signal registration out into WebKitWebViewWPE.cpp. (But not for GTK, because that would break the introspection.) That might be acceptable if we never care about making the WPE API introspectable.
If we do care about WPE introspection, then I don't know what to suggest.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Garcia Campos
(In reply to Michael Catanzaro from comment #0)
> [84/87] Generating ../../WebKit2-4.0.gir
> ../../../../../../Projects/WebKit/Source/WebKit/UIProcess/API/glib/
> WebKitWebView.cpp:2137: Warning: WebKit2: multiple comment blocks
> documenting 'WebKitWebView::show-option-menu:' identifier (already seen at
> WebKitWebView.cpp:2101).
> ../../../../../../Projects/WebKit/Source/WebKit/UIProcess/API/glib/
> WebKitWebView.cpp:2137: Warning: WebKit2: incorrect number of parameters in
> comment block, parameter annotations will be ignored.
>
> The problem is that introspection scanner doesn't respect #if PLATFORM(WPE).
Some how it does, the gir generated is correct. The backend property is inside PLATFORM(WPE) ifdef and it's not included in the gir. The same happens in gtk-doc generated html.
> I tried adding #ifndef __GI_SCANNER__ but that didn't work. I think it's
> going to require adding a platformClassInit() call in order to split the WPE
> signal registration out into WebKitWebViewWPE.cpp. (But not for GTK, because
> that would break the introspection.) That might be acceptable if we never
> care about making the WPE API introspectable.
>
> If we do care about WPE introspection, then I don't know what to suggest.
Michael Catanzaro
So... the gi-scanner is warning that it is doing the wrong thing, but nevertheless doing the right thing...?
I don't plan to investigate further, just wanted to report this nasty warning.
Michael Catanzaro
Maybe we can fix this as part of supporting two GTK API versions at the same time. I've set "Blocks: GTK4" so we don't forget.
Michael Catanzaro
Was already fixed via 238659@main. I just forgot.
*** This bug has been marked as a duplicate of bug 222985 ***