Bug 206787

Summary: WebCore: Remove iOS 11 macros from RenderThemeIOS.mm
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: WebCore Misc.Assignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, dino, esprehn+autocc, ews-watchlist, glenn, jonlee, kondapallykalyan, pdr, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=206096
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Bedard
Reported 2020-01-24 17:50:50 PST
There are a number of platform checks that are implemented as version checks in this file.
Attachments
Patch (4.47 KB, patch)
2020-01-24 17:54 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (4.53 KB, patch)
2020-01-27 07:37 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2020-01-24 17:54:05 PST
Created attachment 388751 [details] Patch
Darin Adler
Comment 2 2020-01-25 09:40:46 PST
Comment on attachment 388751 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388751&action=review > Source/WTF/wtf/PlatformHave.h:571 > +#define HAVE_FONT_STYLE_0 1 > +#define HAVE_FONT_STYLE_4 1 I think "font style 0" is simply too brief to be unambiguous. I think it should be more like SYSTEM_FONT_STYLE_TITLE_0. > Source/WebCore/rendering/RenderThemeIOS.mm:1269 > +#if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) Forgot to use HAVE here. > Source/WebCore/rendering/RenderThemeIOS.mm:1287 > +#if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) And here.
Jonathan Bedard
Comment 3 2020-01-27 07:37:28 PST
Created attachment 388857 [details] Patch
WebKit Commit Bot
Comment 4 2020-01-27 18:07:11 PST
Comment on attachment 388857 [details] Patch Clearing flags on attachment: 388857 Committed r255219: <https://trac.webkit.org/changeset/255219>
WebKit Commit Bot
Comment 5 2020-01-27 18:07:13 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2020-01-27 18:08:15 PST
<rdar://problem/58942377>
Note You need to log in before you can comment on or make changes to this bug.