Bug 206784

Summary: Make ContentWorlds be identified by an ObjectIdentifier instead of a uint64_t
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Brady Eidson 2020-01-24 16:50:38 PST
Make ContentWorlds be identified by an ObjectIdentifier instead of a uin64_t
Comment 1 Brady Eidson 2020-01-24 16:54:38 PST
Created attachment 388743 [details]
Patch
Comment 2 Brady Eidson 2020-01-24 22:37:16 PST
Created attachment 388762 [details]
Patch
Comment 3 Brady Eidson 2020-01-24 22:56:42 PST
Created attachment 388763 [details]
Patch
Comment 4 Brady Eidson 2020-01-25 09:36:34 PST
Failures:
WKUserContentController.ScriptMessageHandlerBasicPostIsolatedWorld
UserContentWorld.IsolatedWorldUserScript


I'd tried to make it so custom worlds do not conflict with the page content world, but certain API use cases still make it possible.

Update that definitely takes care of it is coming.
Comment 5 Brady Eidson 2020-01-25 09:38:37 PST
Created attachment 388778 [details]
Patch
Comment 6 WebKit Commit Bot 2020-01-25 21:02:41 PST
The commit-queue encountered the following flaky tests while processing attachment 388778 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2020-01-25 21:03:05 PST
The commit-queue encountered the following flaky tests while processing attachment 388778 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2020-01-25 21:43:01 PST
The commit-queue encountered the following flaky tests while processing attachment 388778 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2020-01-25 21:43:34 PST
Comment on attachment 388778 [details]
Patch

Clearing flags on attachment: 388778

Committed r255127: <https://trac.webkit.org/changeset/255127>
Comment 10 WebKit Commit Bot 2020-01-25 21:43:35 PST
All reviewed patches have been landed.  Closing bug.