Summary: | Make ContentWorlds be identified by an ObjectIdentifier instead of a uint64_t | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||
Component: | WebKit Misc. | Assignee: | Brady Eidson <beidson> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, webkit-bug-importer | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Brady Eidson
2020-01-24 16:50:38 PST
Created attachment 388743 [details]
Patch
Created attachment 388762 [details]
Patch
Created attachment 388763 [details]
Patch
Failures: WKUserContentController.ScriptMessageHandlerBasicPostIsolatedWorld UserContentWorld.IsolatedWorldUserScript I'd tried to make it so custom worlds do not conflict with the page content world, but certain API use cases still make it possible. Update that definitely takes care of it is coming. Created attachment 388778 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 388778 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 388778 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 388778 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 388778 [details] Patch Clearing flags on attachment: 388778 Committed r255127: <https://trac.webkit.org/changeset/255127> All reviewed patches have been landed. Closing bug. |