Bug 206779

Summary: IntlObject's cached strings should be immortal and safe for concurrent access.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, benjamin, cdumez, cmarcelo, dbates, ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bot-watchers-bugzilla, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=206791
Attachments:
Description Flags
proposed patch. ysuzuki: review+

Mark Lam
Reported 2020-01-24 16:15:25 PST
<rdar://problem/58831763>
Attachments
proposed patch. (8.90 KB, patch)
2020-01-24 16:26 PST, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2020-01-24 16:26:48 PST
Created attachment 388738 [details] proposed patch.
Yusuke Suzuki
Comment 2 2020-01-24 16:41:34 PST
Comment on attachment 388738 [details] proposed patch. r=me
Mark Lam
Comment 3 2020-01-24 17:38:18 PST
I fixed the test to only run with the runDefault configuration. Landed in r255112:<http://trac.webkit.org/r255112>.
Aakash Jain
Comment 4 2020-01-28 05:41:07 PST
(In reply to Mark Lam from comment #3) > Landed in r255112:<http://trac.webkit.org/r255112>. It seems like this introduced a test failure on JSC ARMv7. EWS did indicated the failure. The commit probably fixed the jsc failure, but not the jsc-armv7 failure. Tracked in https://bugs.webkit.org/show_bug.cgi?id=206869
Mark Lam
Comment 5 2020-01-28 09:07:23 PST
(In reply to Aakash Jain from comment #4) > (In reply to Mark Lam from comment #3) > > Landed in r255112:<http://trac.webkit.org/r255112>. > It seems like this introduced a test failure on JSC ARMv7. EWS did indicated > the failure. The commit probably fixed the jsc failure, but not the > jsc-armv7 failure. > > Tracked in https://bugs.webkit.org/show_bug.cgi?id=206869 Already fixed in https://bugs.webkit.org/show_bug.cgi?id=206791.
Note You need to log in before you can comment on or make changes to this bug.