Bug 206762

Summary: Remove check-xcfilelists.sh from WebKitLegacy Xcode build target
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, commit-queue, rmondello, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2020-01-24 11:36:43 PST
When check-xcfilelists.sh got added to the WebKitLegacy Xcode project, it was also accidentally added to the WebKitLegacy build target. This caused it to be treated as a "resource", and so was copied to the output directory in the Resources sub-folder during the build. Remove check-xcfilelists.sh from the target, which also removes it from the Copy Resources build phase, which removes it from the WebKitLegacy.framework/Resources directory.
Attachments
Patch (3.29 KB, patch)
2020-01-24 11:39 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Rollin
Comment 1 2020-01-24 11:36:56 PST
<rdar://problem/58825997>
Keith Rollin
Comment 2 2020-01-24 11:39:17 PST
Created attachment 388712 [details] Patch
Alexey Proskuryakov
Comment 3 2020-01-24 12:58:24 PST
Comment on attachment 388712 [details] Patch rs=me
WebKit Commit Bot
Comment 4 2020-01-24 14:18:35 PST
The commit-queue encountered the following flaky tests while processing attachment 388712 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2020-01-24 14:19:07 PST
Comment on attachment 388712 [details] Patch Clearing flags on attachment: 388712 Committed r255094: <https://trac.webkit.org/changeset/255094>
WebKit Commit Bot
Comment 6 2020-01-24 14:19:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.