Bug 206762 - Remove check-xcfilelists.sh from WebKitLegacy Xcode build target
Summary: Remove check-xcfilelists.sh from WebKitLegacy Xcode build target
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
Keywords: InRadar
Depends on:
Reported: 2020-01-24 11:36 PST by Keith Rollin
Modified: 2020-01-24 14:19 PST (History)
5 users (show)

See Also:

Patch (3.29 KB, patch)
2020-01-24 11:39 PST, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2020-01-24 11:36:43 PST
When check-xcfilelists.sh got added to the WebKitLegacy Xcode project, it was also accidentally added to the WebKitLegacy build target. This caused it to be treated as a "resource", and so was copied to the output directory in the Resources sub-folder during the build. Remove check-xcfilelists.sh from the target, which also removes it from the Copy Resources build phase, which removes it from the WebKitLegacy.framework/Resources directory.
Comment 1 Keith Rollin 2020-01-24 11:36:56 PST
Comment 2 Keith Rollin 2020-01-24 11:39:17 PST
Created attachment 388712 [details]
Comment 3 Alexey Proskuryakov 2020-01-24 12:58:24 PST
Comment on attachment 388712 [details]

Comment 4 WebKit Commit Bot 2020-01-24 14:18:35 PST
The commit-queue encountered the following flaky tests while processing attachment 388712 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2020-01-24 14:19:07 PST
Comment on attachment 388712 [details]

Clearing flags on attachment: 388712

Committed r255094: <https://trac.webkit.org/changeset/255094>
Comment 6 WebKit Commit Bot 2020-01-24 14:19:08 PST
All reviewed patches have been landed.  Closing bug.