Bug 206706

Summary: Get rid of didFinishParsing and make parseInner return its results
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 197106    
Attachments:
Description Flags
patch
mark.lam: review+
patch for landing none

Saam Barati
Reported 2020-01-23 15:34:42 PST
Cleans up some code and makes parseInner less stateful. This should make it easier to eagerly parse IIFE
Attachments
patch (10.94 KB, patch)
2020-01-23 17:26 PST, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
patch for landing (10.97 KB, patch)
2020-01-23 18:09 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2020-01-23 17:26:43 PST
Created attachment 388626 [details] patch
Mark Lam
Comment 2 2020-01-23 17:31:08 PST
Comment on attachment 388626 [details] patch r=me
Keith Miller
Comment 3 2020-01-23 17:31:19 PST
Comment on attachment 388626 [details] patch r=me.
Yusuke Suzuki
Comment 4 2020-01-23 17:31:24 PST
Comment on attachment 388626 [details] patch r=me too, nice. didFinishParsing looks ugly.
Saam Barati
Comment 5 2020-01-23 18:09:48 PST
Created attachment 388632 [details] patch for landing
WebKit Commit Bot
Comment 6 2020-01-23 18:54:42 PST
Comment on attachment 388632 [details] patch for landing Clearing flags on attachment: 388632 Committed r255047: <https://trac.webkit.org/changeset/255047>
WebKit Commit Bot
Comment 7 2020-01-23 18:54:44 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-01-23 18:55:14 PST
<rdar://problem/58857211>
Yusuke Suzuki
Comment 9 2020-01-23 21:42:01 PST
Committed r255053: <https://trac.webkit.org/changeset/255053>
Saam Barati
Comment 10 2020-01-24 11:12:16 PST
(In reply to Yusuke Suzuki from comment #9) > Committed r255053: <https://trac.webkit.org/changeset/255053> oops. Thanks for fixing
Note You need to log in before you can comment on or make changes to this bug.