Bug 206704

Summary: [Mac wk2 Release] fast/html/marquee-child-wrap.html flaky failing
Product: WebKit Reporter: Jason Lawrence <Lawrence.j>
Component: Tools / TestsAssignee: Truitt Savell <tsavell>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jbedard, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=207793
Attachments:
Description Flags
Patch
none
Patch none

Comment 1 Radar WebKit Bug Importer 2020-01-23 15:02:14 PST 
<rdar://problem/58850010>
Comment 2 Alexey Proskuryakov 2020-01-26 12:28:42 PST 
Looks like a bad test, should be easily fixable by adding a large scrolldelay.
Comment 3 Truitt Savell 2020-01-27 10:53:04 PST 
Created attachment 388873 [details]
Patch
Comment 4 Jonathan Bedard 2020-01-27 11:08:30 PST 
Comment on attachment 388873 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388873&action=review

> LayoutTests/fast/html/marquee-child-wrap.html:2
> +<marquee style="border:2px solid green"><span>Text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text</span> scrolldelay="10">scrolldelay = 10</marquee>

I would expect this to be in the <marquee> tag like so:

<marquee style="border:2px solid green" scrolldelay="10">
Comment 5 Truitt Savell 2020-01-27 11:21:24 PST 
Created attachment 388876 [details]
Patch
Comment 6 Truitt Savell 2020-01-27 11:22:02 PST 
(In reply to Truitt Savell from comment #5)
> Created attachment 388876 [details]
> Patch

(In reply to Jonathan Bedard from comment #4)
> Comment on attachment 388873 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388873&action=review
> 
> > LayoutTests/fast/html/marquee-child-wrap.html:2
> > +<marquee style="border:2px solid green"><span>Text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text text</span> scrolldelay="10">scrolldelay = 10</marquee>
> 
> I would expect this to be in the <marquee> tag like so:
> 
> <marquee style="border:2px solid green" scrolldelay="10">

Made this change and upped the delay. Test passed locally.
Comment 7 Alexey Proskuryakov 2020-01-27 13:03:36 PST 
Comment on attachment 388876 [details]
Patch

Why not make it outrageously high, e.g. 10 minutes?
Comment 8 WebKit Commit Bot 2020-01-27 14:36:05 PST 
The commit-queue encountered the following flaky tests while processing attachment 388876 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2020-01-27 14:36:27 PST 
The commit-queue encountered the following flaky tests while processing attachment 388876 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 10 WebKit Commit Bot 2020-01-27 15:05:16 PST 
The commit-queue encountered the following flaky tests while processing attachment 388876 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 11 WebKit Commit Bot 2020-01-27 15:05:47 PST 
Comment on attachment 388876 [details]
Patch

Clearing flags on attachment: 388876

Committed r255181: <https://trac.webkit.org/changeset/255181>
Comment 12 WebKit Commit Bot 2020-01-27 15:05:48 PST 
All reviewed patches have been landed.  Closing bug.