Bug 206700

Summary: Centralize AuxiliaryProcessMainBase implementations
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: WebKit2Assignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, cgarcia, clopez, commit-queue, ews-watchlist, gyuyoung.kim, Hironori.Fujii, ryuan.choi, sergio, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
none
WIP Patch
none
WIP Patch
none
WIP Patch
none
Patch none

Don Olmstead
Reported 2020-01-23 13:58:44 PST
Non-Cocoa ports are using AuxiliaryProcessMainBase for their entry points to WebProcess and NetworkProcess. These should be centralized and use a common naming.
Attachments
WIP Patch (19.34 KB, patch)
2020-01-23 15:26 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
WIP Patch (19.67 KB, patch)
2020-01-23 15:48 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
WIP Patch (19.77 KB, patch)
2020-01-23 15:56 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
WIP Patch (22.89 KB, patch)
2020-01-23 16:10 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (25.52 KB, patch)
2020-01-23 16:45 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2020-01-23 15:26:32 PST Comment hidden (obsolete)
Don Olmstead
Comment 2 2020-01-23 15:48:13 PST Comment hidden (obsolete)
Don Olmstead
Comment 3 2020-01-23 15:56:38 PST Comment hidden (obsolete)
Don Olmstead
Comment 4 2020-01-23 16:10:51 PST Comment hidden (obsolete)
Don Olmstead
Comment 5 2020-01-23 16:45:55 PST
Created attachment 388616 [details] Patch Since a lot of stuff is renamed or moved the diff might be a bit weird. Other than that ready to review by Team Igalia!
WebKit Commit Bot
Comment 6 2020-01-24 06:11:30 PST
Comment on attachment 388616 [details] Patch Clearing flags on attachment: 388616 Committed r255067: <https://trac.webkit.org/changeset/255067>
WebKit Commit Bot
Comment 7 2020-01-24 06:11:32 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-01-24 06:12:15 PST
<rdar://problem/58866155>
Fujii Hironori
Comment 9 2020-01-26 21:50:33 PST
Comment on attachment 388616 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388616&action=review > Source/WebKit/NetworkProcess/curl/NetworkProcessMainCurl.cppSource/WebKit/NetworkProcess/win/NetworkProcessMainWin.cpp:40 > + globalNetworkProcess->destroySession(PAL::SessionID::defaultSessionID()); Filed: Bug 206817 – [WinCairo][curl] ASSERTION FAILED: sessionID != PAL::SessionID::defaultSessionID() in NetworkProcess since r255067
Note You need to log in before you can comment on or make changes to this bug.