Bug 206680

Summary: [ macOS ] fast/frames/sandboxed-iframe-navigation-allowed.html is flaky failing
Product: WebKit Reporter: Jacob Uphoff <jacob_uphoff>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, ggaren, rniwa, sam, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=215745
Attachments:
Description Flags
Update Test Expectations
none
Update Test Expectations
none
Patch
none
Patch none

Jacob Uphoff
Reported 2020-01-23 10:51:48 PST
fast/frames/sandboxed-iframe-navigation-allowed.html is flaky failing on Catalina and Mojave wk1 I did not try to reproduce History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fframes%2Fsandboxed-iframe-navigation-allowed.html Diff: --- /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/fast/frames/sandboxed-iframe-navigation-allowed-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/fast/frames/sandboxed-iframe-navigation-allowed-actual.txt @@ -4,7 +4,7 @@ PASS (self.sandboxedFrame.frameWithPlugin.document.getElementById('plugin').destroyStream) == undefined is true -PASS (self.frameWithPlugin.document.getElementById('plugin').destroyStream) != undefined is true +FAIL (self.frameWithPlugin.document.getElementById('plugin').destroyStream) != undefined should be true. Threw exception TypeError: null is not an object (evaluating 'self.frameWithPlugin.document.getElementById('plugin').destroyStream') PASS String(document.getElementById('sandboxedFrameId').sandbox) is "allow-scripts allow-same-origin" PASS successfullyParsed is true
Attachments
Update Test Expectations (1.44 KB, patch)
2020-01-27 14:07 PST, Jacob Uphoff 		no flags
DetailsFormatted DiffDiff
Update Test Expectations (1.42 KB, patch)
2020-01-27 14:15 PST, Jacob Uphoff 		no flags
DetailsFormatted DiffDiff
Patch (2.42 KB, patch)
2020-03-12 15:33 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.91 KB, patch)
2020-03-13 09:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-01-23 10:52:18 PST
<rdar://problem/58840416>
Truitt Savell
Comment 2 2020-01-23 15:50:50 PST
This test is a highly intermittent failure. It has failed throughout the visible history.
Jacob Uphoff
Comment 3 2020-01-27 14:07:57 PST
Created attachment 388906 [details] Update Test Expectations
Jacob Uphoff
Comment 4 2020-01-27 14:15:52 PST
Created attachment 388908 [details] Update Test Expectations
Truitt Savell
Comment 5 2020-01-27 14:17:35 PST
Comment on attachment 388908 [details] Update Test Expectations Clearing flags on attachment: 388908 Committed r255176: <https://trac.webkit.org/changeset/255176>
Chris Dumez
Comment 6 2020-03-12 15:33:33 PDT
Created attachment 393422 [details] Patch
Alexey Proskuryakov
Comment 7 2020-03-12 15:52:45 PDT
Comment on attachment 393422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393422&action=review > LayoutTests/fast/frames/resources/sandboxed-iframe-navigation-child.html:-6 > - self.navigated.location.assign("javascript: top.childFrameWasNavigated();"); Isn't the test all about executing this code in a subframe?
Chris Dumez
Comment 8 2020-03-12 17:01:27 PDT
Comment on attachment 393422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393422&action=review >> LayoutTests/fast/frames/resources/sandboxed-iframe-navigation-child.html:-6 >> - self.navigated.location.assign("javascript: top.childFrameWasNavigated();"); > > Isn't the test all about executing this code in a subframe? Looking at the test description, I think you are right that this is part of the thing that was tested (should be able to navigate subframe). I will address the flakiness some other way then.
Chris Dumez
Comment 9 2020-03-13 09:25:21 PDT
Created attachment 393487 [details] Patch
WebKit Commit Bot
Comment 10 2020-03-13 10:15:04 PDT
Comment on attachment 393487 [details] Patch Clearing flags on attachment: 393487 Committed r258405: <https://trac.webkit.org/changeset/258405>
WebKit Commit Bot
Comment 11 2020-03-13 10:15:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.