Summary: | [ macOS ] fast/frames/sandboxed-iframe-navigation-allowed.html is flaky failing | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jacob Uphoff <jacob_uphoff> | ||||||||||
Component: | Tools / Tests | Assignee: | Chris Dumez <cdumez> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, cdumez, commit-queue, ggaren, rniwa, sam, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=215745 | ||||||||||||
Attachments: |
|
Description
Jacob Uphoff
2020-01-23 10:51:48 PST
This test is a highly intermittent failure. It has failed throughout the visible history. Created attachment 388906 [details]
Update Test Expectations
Created attachment 388908 [details]
Update Test Expectations
Comment on attachment 388908 [details] Update Test Expectations Clearing flags on attachment: 388908 Committed r255176: <https://trac.webkit.org/changeset/255176> Created attachment 393422 [details]
Patch
Comment on attachment 393422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393422&action=review > LayoutTests/fast/frames/resources/sandboxed-iframe-navigation-child.html:-6 > - self.navigated.location.assign("javascript: top.childFrameWasNavigated();"); Isn't the test all about executing this code in a subframe? Comment on attachment 393422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393422&action=review >> LayoutTests/fast/frames/resources/sandboxed-iframe-navigation-child.html:-6 >> - self.navigated.location.assign("javascript: top.childFrameWasNavigated();"); > > Isn't the test all about executing this code in a subframe? Looking at the test description, I think you are right that this is part of the thing that was tested (should be able to navigate subframe). I will address the flakiness some other way then. Created attachment 393487 [details]
Patch
Comment on attachment 393487 [details] Patch Clearing flags on attachment: 393487 Committed r258405: <https://trac.webkit.org/changeset/258405> All reviewed patches have been landed. Closing bug. |