Bug 206646
| Summary: | REGRESSION (r254329?): safaridriver regression in "find elements" command | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Philip Jägenstedt <philip> |
| Component: | WebDriver | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED MOVED | ||
| Severity: | Normal | CC: | bburg, cgarcia, simon.fraser, w0nka, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=204151 | ||
Philip Jägenstedt
In https://github.com/web-platform-tests/wpt/pull/21369 I have debugged why there are new failures in STP 99 compared to STP 98:
https://github.com/web-platform-tests/wpt/pull/21359#issuecomment-577519963
At the root of it is a "JavaScriptError;Unexpected keyword 'function'. Expected ')' to end a compound expression." which seems to be a failure to execute an internal script called WDFindNodes.js.
In https://wpt.fyi/results/webdriver/tests?diff&filter=ADC&run_id=416830016&run_id=393600011 it looks like this affects many WebDriver endpoints, not just "find elements".
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/58838680>
Blaze Burg
Can confirm this is a recent regression, not sure where the fix is yet. I am assuming that the regression point is <https://trac.webkit.org/changeset/254329/webkit> but I have not confirmed. Will keep this updated as I dig further with a debug build.
Blaze Burg
r254329 indeed caused a problem with how safaridriver inserts sourceURL directives.
A fix has been submitted for review on the safaridriver side.
No fix needed in WebKit, thus no further updates will be provided here. The fix should be included in the next release of Safari Technology Preview.
Unfortunately there is no workaround for this issue in STP99.
Blaze Burg
*** Bug 206827 has been marked as a duplicate of this bug. ***