Bug 206623

Summary: Add an option for logging total phase times
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch for landing none

Saam Barati
Reported 2020-01-22 15:53:01 PST
...
Attachments
patch (7.15 KB, patch)
2020-01-22 17:08 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch for landing (7.23 KB, patch)
2020-01-22 17:18 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2020-01-22 17:08:11 PST
Created attachment 388490 [details] patch
Robin Morisset
Comment 2 2020-01-22 17:13:22 PST
Comment on attachment 388490 [details] patch r=me
Keith Miller
Comment 3 2020-01-22 17:15:17 PST
Comment on attachment 388490 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=388490&action=review r=me too with comment. > Source/JavaScriptCore/runtime/OptionsList.h:167 > + v(Bool, reportTotalPhaseTimes, false, Normal, nullptr) \ Plox add a string here that explains the difference between this only prints at the end.
Saam Barati
Comment 4 2020-01-22 17:18:34 PST
Created attachment 388492 [details] patch for landing
WebKit Commit Bot
Comment 5 2020-01-22 18:27:31 PST
Comment on attachment 388492 [details] patch for landing Clearing flags on attachment: 388492 Committed r254957: <https://trac.webkit.org/changeset/254957>
WebKit Commit Bot
Comment 6 2020-01-22 18:27:32 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2020-01-22 18:28:13 PST
<rdar://problem/58820257>
Note You need to log in before you can comment on or make changes to this bug.