Bug 206622

Summary: Legacy WebKit: Add SPI variant of -setSelectedDOMRange that can perform the selection as if triggered by the user
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Daniel Bates
Reported 2020-01-22 15:50:13 PST
Add Legacy WebKit SPI that does what Modern WebKit IPI WebPage::selectPositionAtPoint() does.
Attachments
Patch (5.36 KB, patch)
2020-01-22 16:07 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (5.42 KB, patch)
2020-01-22 16:19 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2020-01-22 15:52:05 PST
This SPI will be used to select the position on the page as if the user had done it.
Daniel Bates
Comment 2 2020-01-22 16:07:24 PST
Created attachment 388480 [details] Patch
Daniel Bates
Comment 3 2020-01-22 16:12:18 PST
Comment on attachment 388480 [details] Patch Hold up... I didn't actually add the function I wanted. Haha
Daniel Bates
Comment 4 2020-01-22 16:18:52 PST
Change of plans... re-purposes this bug to just do what the patch does (though I will post a new patch to update the ChangeLog): add a new SPI variant of -setSelectedDOMRange that takes a bool as to whether the selection is user triggered.
Daniel Bates
Comment 5 2020-01-22 16:19:39 PST
Created attachment 388482 [details] Patch
Daniel Bates
Comment 6 2020-01-22 16:23:00 PST
Thanks for the review, Wenson!
Daniel Bates
Comment 7 2020-01-22 16:24:30 PST
Comment on attachment 388482 [details] Patch Clearing flags on attachment: 388482 Committed r254952: <https://trac.webkit.org/changeset/254952>
Daniel Bates
Comment 8 2020-01-22 16:24:31 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2020-01-22 16:25:13 PST
<rdar://problem/58815760>
Note You need to log in before you can comment on or make changes to this bug.