Bug 206561

Summary: Add missing NS_NOESCAPE to CFNetwork SPI
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch joepeck: review+

Alex Christensen
Reported 2020-01-21 16:20:19 PST
Add missing NS_NOESCAPE to CFNetwork SPI
Attachments
Patch (3.41 KB, patch)
2020-01-21 16:27 PST, Alex Christensen 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-01-21 16:27:29 PST
Created attachment 388369 [details] Patch
Alex Christensen
Comment 2 2020-01-21 16:27:32 PST
<rdar://problem/58774422>
Joseph Pecoraro
Comment 3 2020-01-21 17:28:16 PST
Comment on attachment 388369 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388369&action=review r=me > Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:-49 > -#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 120000) > -@interface NSHTTPCookieStorage (Staging) > -- (void)_getCookiesForURL:(NSURL *)url mainDocumentURL:(NSURL *)mainDocumentURL partition:(NSString *)partition policyProperties:(NSDictionary*)props completionHandler:(void (^)(NSArray *))completionHandler; > -- (void)_setCookies:(NSArray *)cookies forURL:(NSURL *)URL mainDocumentURL:(NSURL *)mainDocumentURL policyProperties:(NSDictionary*) props; > -@end > -#endif Nice!
Alex Christensen
Comment 4 2020-01-21 17:30:30 PST
https://trac.webkit.org/changeset/254895/webkit
Note You need to log in before you can comment on or make changes to this bug.