Bug 206559

Summary: REGRESSION(r254807): Broke page up/page down on macOS (Requested by smfr on #webkit).
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: cathiechen, fred.wang, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 204882    
Attachments:
Description Flags
ROLLOUT of r254807 none

WebKit Commit Bot
Reported 2020-01-21 15:36:18 PST
https://trac.webkit.org/changeset/254807 broke the build: Broke page up/page down on macOW (Requested by smfr on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
ROLLOUT of r254807 (90.11 KB, patch)
2020-01-21 15:36 PST, WebKit Commit Bot 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2020-01-21 15:36:32 PST
Created attachment 388361 [details] ROLLOUT of r254807 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Simon Fraser (smfr)
Comment 2 2020-01-21 15:37:17 PST
*** Bug 206553 has been marked as a duplicate of this bug. ***
Simon Fraser (smfr)
Comment 3 2020-01-21 15:38:41 PST
Sorry about the rollout, but I couldn't easily fix. Some debugging in 206553.
WebKit Commit Bot
Comment 4 2020-01-21 15:38:57 PST
Comment on attachment 388361 [details] ROLLOUT of r254807 Clearing flags on attachment: 388361 Committed r254890: <https://trac.webkit.org/changeset/254890>
WebKit Commit Bot
Comment 5 2020-01-21 15:38:58 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2020-01-21 15:39:19 PST
<rdar://problem/58776888>
Note You need to log in before you can comment on or make changes to this bug.