Bug 206540

Summary: [macOS] Add managed preference to allow synchronous XHR during page dismissal
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, dbates, ews-watchlist, ggaren, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=206944
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2020-01-21 09:41:45 PST
Add managed preference to allow synchronous XHR during page dismissal. This is temporarily needed by some enterprise products until they can update their code.
Attachments
Patch (3.09 KB, patch)
2020-01-21 09:46 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (5.16 KB, patch)
2020-01-21 12:52 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-01-21 09:43:11 PST
<rdar://problem/58644447>
Chris Dumez
Comment 2 2020-01-21 09:46:18 PST
Created attachment 388311 [details] Patch
Alex Christensen
Comment 3 2020-01-21 12:41:47 PST
Comment on attachment 388311 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388311&action=review r=me > Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:67 > +bool defaultDisallowSyncXHRDuringPageDismissalEnabled() To avoid double negatives, could we rename this to defaultAllow... Same with the preference name. > Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:75 > + return true; We should put a FIXME with a radar for iOS.
Chris Dumez
Comment 4 2020-01-21 12:52:34 PST
Created attachment 388338 [details] Patch
Chris Dumez
Comment 5 2020-01-21 14:02:44 PST
Comment on attachment 388338 [details] Patch The changed proposed by Alex does not work because WebKitTestRunner turns ON all experimental features.
Chris Dumez
Comment 6 2020-01-21 14:04:19 PST
Committed r254880: <https://trac.webkit.org/changeset/254880>
Note You need to log in before you can comment on or make changes to this bug.