Bug 206518

Summary: Rename JSPromiseFields abstract heap to JSInternalFields.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, msaboff, saam, tuomas.webkit, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
proposed patch none

Mark Lam
Reported 2020-01-20 23:43:22 PST
This is because it is used for all internal fields, not just the ones in JSPromise.
Attachments
proposed patch. (2.22 KB, patch)
2020-01-20 23:50 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch (9.11 KB, patch)
2020-01-21 04:29 PST, Tuomas Karkkainen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-01-20 23:43:45 PST
<rdar://problem/58751778>
Mark Lam
Comment 2 2020-01-20 23:50:18 PST
Created attachment 388281 [details] proposed patch.
Yusuke Suzuki
Comment 3 2020-01-21 00:57:44 PST
Comment on attachment 388281 [details] proposed patch. r=me
WebKit Commit Bot
Comment 4 2020-01-21 01:41:08 PST
Comment on attachment 388281 [details] proposed patch. Clearing flags on attachment: 388281 Committed r254846: <https://trac.webkit.org/changeset/254846>
WebKit Commit Bot
Comment 5 2020-01-21 01:41:10 PST
All reviewed patches have been landed. Closing bug.
Tuomas Karkkainen
Comment 6 2020-01-21 04:29:54 PST
Created attachment 388289 [details] proposed patch - fixes Tools/Scripts/set-webkit-configuration --reset - addresses some comments
Tuomas Karkkainen
Comment 7 2020-01-21 04:31:04 PST
(In reply to Tuomas Karkkainen from comment #6) > Created attachment 388289 [details] > proposed patch > > - fixes Tools/Scripts/set-webkit-configuration --reset > - addresses some comments oops wrong issue.
Note You need to log in before you can comment on or make changes to this bug.